Materialized cached_ds

Signed-off-by: Elena Khaustova <[email protected]>
kedro-org · Nov 14, 2024 · e3289b4 · e3289b4
1 parent 8795dd6
commit e3289b4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/kedro/io/kedro_data_catalog.py b/kedro/io/kedro_data_catalog.py
@@ -284,7 +284,7 @@ def to_config(
             )
             catalog[ds_name] = unresolved_config
             credentials.update(unresolved_credentials)
-            # TODO: Update when resolve #4327
+            # TODO: Update when #4327 resolved
             if catalog[ds_name].get(VERSIONED_FLAG_KEY, None):
                 load_version[ds_name] = ds.load_version
                 save_version[ds_name] = ds.save_version

diff --git a/tests/io/conftest.py b/tests/io/conftest.py
@@ -75,13 +75,14 @@ def correct_config_versioned(filepath):
                 "save_args": {"sep": ",", "nullstr": "#NA"},
             },
             "cached_ds": {
-                "type": "CachedDataset",
-                "versioned": "true",
+                "type": "kedro.io.cached_dataset.CachedDataset",
+                "versioned": True,
                 "dataset": {
                     "type": "pandas.CSVDataset",
                     "filepath": "cached_ds.csv",
                     "credentials": "cached_ds_credentials",
                 },
+                "copy_mode": None,
             },
         },
         "credentials": {

diff --git a/tests/io/test_kedro_data_catalog.py b/tests/io/test_kedro_data_catalog.py
@@ -303,6 +303,8 @@ def test_to_config(self, correct_config_versioned, dataset, filepath):
             catalog = KedroDataCatalog.from_config(config, credentials)
             catalog["resolved_ds"] = dataset
             catalog["memory_ds"] = [1, 2, 3]
+            # Materialize cached_ds
+            _ = catalog["cached_ds"]
 
             version = Version(
                 load="fake_load_version.csv",  # load exact version
@@ -347,6 +349,8 @@ def test_to_config(self, correct_config_versioned, dataset, filepath):
             }
             expected_config.update(config)
 
+            # TODO: Add expected load/save versions when #4327 resolved
+
             assert catalog_config == expected_config
             assert catalog_credentials == credentials