Fix/ensure Created by is set in Experiment Tracking
#937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Tynan DeBold <[email protected]>
tynandebold
changed the title
Created by is set in Experiment TrackingCreated by is set in Experiment Tracking
tynandebold
commented
Jun 22, 2022
| @@ -117,6 +117,7 @@ const RunMetadata = ({ | |||
| <tr> | |||
| <td className="details-metadata__title" colSpan="2"> | |||
| <span | |||
| className="details-metadata__title-detail" | |||
There was a problem hiding this comment.
This is to fix the title font not being correct here (second edit):
tynandebold
commented
Jun 22, 2022
| @@ -72,7 +72,7 @@ def format_run( | |||
| user_run_details.notes if user_run_details and user_run_details.notes else "" | |||
| ) | |||
| run = Run( | |||
| author="", | |||
| author=run_blob.get("username"), | |||
There was a problem hiding this comment.
This is the operative change in this PR.
…x/created-by-is-empty-exp-tracking Signed-off-by: Tynan DeBold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tynan DeBold [email protected]
Description
Fixes #911.
Development notes
It was a one-line fix. The
authorfield wasn't being set, and now it is.QA notes
Take a look at the Gitpod link and view the most-recent run. The field should be filled in.
This PR also includes a tiny fix of a style inconsistency for exp. tracking run titles that was introduced in #919.
Checklist
RELEASE.mdfile