Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update demo project to use Kedro 0.18.1 #848

Merged
merged 4 commits into from
May 16, 2022
Merged

Update demo project to use Kedro 0.18.1 #848

merged 4 commits into from
May 16, 2022

Conversation

tynandebold
Copy link
Member

@tynandebold tynandebold commented May 12, 2022 •
edited
Loading

Signed-off-by: Tynan DeBold [email protected]

Description

Our demo site was failing to deploy because of this:

Invalid value `kedro.config.templated_config.TemplatedConfigLoader` received...

So this PR updates the demo-project to the latest version of Kedro, which is 0.18.1, and that error should disappear.

QA notes

Checkout the repo, pip install kedro==0.18.1 in the /demo-project folder, and then run make run in the root of the project. The server should start without a hitch.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@tynandebold
update demo project to 0.18.1
ac1bd25 
Signed-off-by: Tynan DeBold <[email protected]>
@tynandebold tynandebold changed the title Update demo project to 0.18.1 Update demo project to use Kedro 0.18.1 May 12, 2022
antonymilne
antonymilne approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to understand: is this just to get the demo site working again?

@tynandebold
Copy link
Member Author

Just to understand: is this just to get the demo site working again?

Yes indeed. Thanks for checking. I should've initially put that in the PR description. I've added it now.

@tynandebold tynandebold mentioned this pull request May 16, 2022
Merged
5 tasks
@tynandebold tynandebold requested review from merelcht and removed request for yetudada May 16, 2022 13:35
@tynandebold tynandebold merged commit 4dc2270 into main May 16, 2022
@tynandebold tynandebold deleted the chore/update-demo-project-0.18.1 branch May 16, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merelcht merelcht merelcht approved these changes

@antonymilne antonymilne antonymilne approved these changes

@studioswong studioswong Awaiting requested review from studioswong

@rashidakanchwala rashidakanchwala Awaiting requested review from rashidakanchwala rashidakanchwala is a code owner

@limdauto limdauto Awaiting requested review from limdauto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tynandebold @antonymilne @merelcht