Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-2720] Fix run command suggestion #497

Merged
merged 6 commits into from
Jul 9, 2021
Merged

Conversation

limdauto
Copy link
Collaborator

@limdauto limdauto commented Jul 6, 2021

Description

Fixes #492

This PR moves the run command suggestion logic to the backend and now will show:

  • kedro run --to-nodes="<node name>" for a task node if node name exists. If it doesn’t exist, there will be a help text asking user to add a name property to the node definition (see screenshot).

  • kedro run --to-outputs="<dataset name>" for a data node if the data node is not a free input since free inputs are not output of any node.

Screenshot 2021-07-06 at 17 17 25

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@limdauto limdauto requested review from bru5, rashidakanchwala and studioswong and removed request for bru5 July 6, 2021 16:17
@limdauto limdauto changed the title Move run_command for task to the backend [KED-2720] Fix run command suggestion Jul 6, 2021
@limdauto limdauto marked this pull request as draft July 7, 2021 09:13
@limdauto limdauto marked this pull request as ready for review July 9, 2021 12:30
Copy link
Contributor

@bru5 bru5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I've approved though I do think that double ternary I commented on is worth thinking about splitting.

@limdauto limdauto merged commit 6be89f4 into main Jul 9, 2021
@limdauto limdauto deleted the KED-2720/run-command branch July 9, 2021 14:01
@studioswong studioswong mentioned this pull request Jul 13, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KED-2720]--to-inputs instead of --to-outputs and prettified names in panel "run command" suggestion
2 participants