Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry code only in production #487

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Add telemetry code only in production #487

merged 2 commits into from
Jun 23, 2021

Conversation

limdauto
Copy link
Collaborator

@limdauto limdauto commented Jun 18, 2021

Description

Inject telemetry code before the </head> element when serving index.html through the server.

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@limdauto limdauto force-pushed the bug/fix-dev-index branch from 6a962f9 to fc8ef03 Compare June 21, 2021 13:09
@limdauto limdauto requested review from studioswong and bru5 June 21, 2021 13:14
@limdauto limdauto force-pushed the bug/fix-dev-index branch from 5be2c87 to 71f33ef Compare June 23, 2021 10:00
@limdauto limdauto changed the title Split index.html into dev and prod versions Add telemetry code only in production Jun 23, 2021
@limdauto limdauto merged commit 6d90843 into main Jun 23, 2021
@limdauto limdauto deleted the bug/fix-dev-index branch June 23, 2021 10:52
@studioswong studioswong mentioned this pull request Jul 13, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants