Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-2186] Hide graph when loading+switching to new pipeline #296

Merged
merged 3 commits into from
Nov 3, 2020

Conversation

richardwestenra
Copy link
Contributor

@richardwestenra richardwestenra commented Nov 3, 2020

Description

I've noticed that often, when loading the graph while changing the pipeline, it's not sufficiently obvious that the chart is still loading. This is because the sidebar updates before the graph does, which gives the impression that it's ready when it isn't yet. This change aims to prevent this by removing the old graph when loading, to make it obvious that the new graph is still being generated.

This PR supercedes #282, which was an alternative fix for the same problem, but had more unwanted side-effects.

Development notes

Resetting the store appears to only take a couple of milliseconds in testing. Removing the old graph probably takes more, but likely not too much time.

QA notes

Load multiple large pipelines asynchronously, and try switching between them. The pipeline graph now disappears when the new one is being loaded and calculated.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@richardwestenra richardwestenra merged commit a185d03 into main Nov 3, 2020
@richardwestenra richardwestenra deleted the feature/hide-pipeline-on-switch branch November 3, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants