Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-2179] Hide random seed message unless using random data #280

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

richardwestenra
Copy link
Contributor

@richardwestenra richardwestenra commented Oct 14, 2020

Description

Prevent the app from console.logging the random data message when random data is not being used as the data source
image

Development notes

This required scoping the seed generation so that it's only executed when the random data generator is called.

QA notes

Check the console with data=random vs e.g. data=demo

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@@ -40,6 +31,7 @@ const LAYERS = [
*/
class Pipeline {
constructor() {
this.utils = randomUtils();
Copy link
Contributor

@bru5 bru5 Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought that I'd prefer utility than utils (or ideally, just random without that prefix on the functions), but that looks like it might require a bigger change than it's worth to be fair.

@richardwestenra richardwestenra merged commit a99ddd8 into main Oct 15, 2020
@richardwestenra richardwestenra deleted the fix/random-data-message branch October 15, 2020 11:03
@richardwestenra richardwestenra mentioned this pull request Oct 20, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants