[KED-1423] Feature/metadata panel #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/components/icon-button/index.js # src/components/icons/node-icon.js # src/config.js # src/styles/_variables.scss
richardwestenra
suggested changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a metadata side panel.
Development notes
This first version is behind flag
metaand only shows existing data, a later update will add data from further APIs.The responsive approach has been adapted to account for the additional sidebar.
QA notes
The metadata flag must be enabled before testing. To see inputs and outputs, the new graph flag must also be enabled (at least for the initial implementation). Here is an example:
http://localhost:4141/?data=demo&newgraph=true&meta=trueThen to see the metadata panel, you should click on any node either in the sidebar or on the chart.
Note that different node types show different information, so test each kind.
To test the responsive approach, test with each sidebar individually and with both open, at sizes below
800px.Checklist
RELEASE.mdfileLegal notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.