Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-2034] Put multi-pipeline selector behind a flag #254

Merged
merged 6 commits into from
Sep 3, 2020

Conversation

richardwestenra
Copy link
Contributor

Description

Put multi-pipeline selector behind a flag, to make it safe to release even while it's still a work-in-progress.

Now, even if you have multiple pipelines available, the selector UI will not be displayed unless you enable the flag.

image

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

This is to make it safe to release even while it's still a work-in-progress
Copy link
Contributor

@bru5 bru5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you try enabling the flag, choosing a pipeline other than default, then disable the flag I think I'd expect it to reset back to the default pipeline. It doesn't seem to do that though, so there might be something missing here from the implementation?

@richardwestenra richardwestenra requested a review from bru5 September 2, 2020 12:10
@richardwestenra richardwestenra merged commit 60b0cf4 into main Sep 3, 2020
@richardwestenra richardwestenra deleted the feature/multi-pipelines-flag branch September 3, 2020 11:57
@richardwestenra richardwestenra mentioned this pull request Sep 8, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants