Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console errors in Minimap component when all nodes are hidden #238

Merged
merged 3 commits into from
Aug 19, 2020

Conversation

richardwestenra
Copy link
Contributor

@richardwestenra richardwestenra commented Aug 12, 2020

Description

The minimap component is throwing errors when there are no nodes displayed on the page.

Development notes

  • Add tests to ensure that this doesn't happen again (because it's not the first time this regression has been introduced)
  • Fix the error

QA notes

Disable all nodes (e.g. by clicking 'Hide all', or disabling each of the 3 node-types)

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

This extra argument probably got added during a merge conflict fix when the argument order was changed around
@richardwestenra richardwestenra requested a review from bru5 August 12, 2020 10:40
@richardwestenra richardwestenra marked this pull request as ready for review August 19, 2020 12:10
@richardwestenra richardwestenra merged commit 0f2b736 into develop Aug 19, 2020
@richardwestenra richardwestenra deleted the fix/empty-data-errors branch August 19, 2020 12:12
@richardwestenra richardwestenra mentioned this pull request Sep 8, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants