Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] use uv to install dependencies #2204

Merged
merged 12 commits into from
Nov 26, 2024
Merged

[DRAFT] use uv to install dependencies #2204

merged 12 commits into from
Nov 26, 2024

Conversation

Huongg
Copy link
Contributor

@Huongg Huongg commented Nov 25, 2024 •
edited
Loading

Description

Fixes #1805

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Huong Nguyen and others added 11 commits November 25, 2024 10:23
use uv to install dependencies
5cac314 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
include install uv before run it
0e985ea 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
install uv in setup test
7d5c578 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
combine uv and install dependencies
97938a9 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
try --system to install dependencies
ee616b8 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
@SajidAlamQB
fix formatting
8f58081 
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
remove uv install from setup
a272986 
Signed-off-by: Sajid Alam <[email protected]>
only install node and fe dependencies if e2e tests run
42d059d 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Merge branch 'fix/CI-runtime' of github.com:kedro-org/kedro-viz into …
e8c30c7 
…fix/CI-runtime
remove the condition as it will be done in a separate ticket
b6b20b7 
Signed-off-by: Huong Nguyen <huongg1409@gmail>
@Huongg
Extra line at the end
8dfe5bf 
Signed-off-by: Huong Nguyen <[email protected]>
astrojuanlu
astrojuanlu approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@Huongg Huongg mentioned this pull request Nov 26, 2024
Open
1 task
@Huongg Huongg marked this pull request as ready for review November 26, 2024 11:10
SajidAlamQB
SajidAlamQB approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Huongg!

@Huongg Huongg merged commit 6c6e8f1 into main Nov 26, 2024
56 checks passed
@Huongg Huongg deleted the fix/CI-runtime branch November 26, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@rashidakanchwala rashidakanchwala Awaiting requested review from rashidakanchwala rashidakanchwala is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve CI on Kedro-Viz
3 participants
@Huongg @astrojuanlu @SajidAlamQB