Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-1729] Add minimap #203

Merged
merged 26 commits into from
Aug 4, 2020
Merged

[KED-1729] Add minimap #203

merged 26 commits into from
Aug 4, 2020

Conversation

bru5
Copy link
Contributor

@bru5 bru5 commented Jul 2, 2020

Description

Adds an interactive minimap to the toolbar.

Screenshot 2020-07-02 at 09 45 20

Development notes

The PR adds a new minimap and toolbar component.

It also makes some changes and improvements to the main flowchart component that were added for performance, so it should now be more efficient in making drawing calls.

QA notes

  • The minimap is opened by clicking the new map button on the sidebar.
  • The size is dynamic depending on the graph size and viewport size.
  • The main view can be panned by dragging the viewport around in the minimap.
  • The minimap is animated and shows highlighting similar to the main view.
  • Toggling labels will also apply to the minimap.
  • Light and dark themes are implemented.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Copy link
Contributor

@richardwestenra richardwestenra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looking good thanks! I'd still like you to update the CSS nesting, but other than that it looks good to go - apart from the tests needing fixing, and also a merge conflict.

bru5 added 2 commits July 30, 2020 17:21
# Conflicts:
#	package-lock.json
#	src/components/flowchart/index.js
#	src/selectors/layout.js
#	src/selectors/layout.test.js
Copy link
Contributor

@richardwestenra richardwestenra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still like for @GabrielComymQB to weigh in on the CSS shadow/highlight, but other than that, nice work!

:shipit:

@bru5
Copy link
Contributor Author

bru5 commented Aug 3, 2020

I'd still like for @GabrielComymQB to weigh in on the CSS shadow/highlight, but other than that, nice work!

:shipit:

Oh I'd actually added these earlier but looks like it wasn't pushed, they're there now.

Copy link
Contributor

@richardwestenra richardwestenra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval intensifies

@bru5 bru5 merged commit 70d3e18 into develop Aug 4, 2020
@bru5 bru5 deleted the feature/minimap branch August 4, 2020 11:07
@richardwestenra richardwestenra mentioned this pull request Sep 8, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants