-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KED-1729] Add minimap #203
Conversation
# Conflicts: # src/actions/index.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, looking good thanks! I'd still like you to update the CSS nesting, but other than that it looks good to go - apart from the tests needing fixing, and also a merge conflict.
# Conflicts: # package-lock.json # src/reducers/index.js
# Conflicts: # package-lock.json # src/components/flowchart/index.js # src/selectors/layout.js # src/selectors/layout.test.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd still like for @GabrielComymQB to weigh in on the CSS shadow/highlight, but other than that, nice work!
Oh I'd actually added these earlier but looks like it wasn't pushed, they're there now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Adds an interactive minimap to the toolbar.
Development notes
The PR adds a new minimap and toolbar component.
It also makes some changes and improvements to the main flowchart component that were added for performance, so it should now be more efficient in making drawing calls.
QA notes
Checklist
RELEASE.md
fileLegal notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.