Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor command copier #1998

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Refactor command copier #1998

merged 3 commits into from
Jul 24, 2024

Conversation

Huongg
Copy link
Contributor

@Huongg Huongg commented Jul 24, 2024

Description

Fixes #1994

Development notes

By abstracting the <MetaDataValue> previously used within the Command Copier component, the component has been made more generic, allowing it to be used throughout the application.

QA notes

When you run locally, if you click on a node, the command line in meta data should look and stay the same as how it was before

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Huong Nguyen added 2 commits July 24, 2024 10:36
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
@Huongg Huongg requested a review from astrojuanlu as a code owner July 24, 2024 10:06
@Huongg Huongg self-assigned this Jul 24, 2024
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Huongg !! LGTM

Copy link
Contributor

@jitu5 jitu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Huongg Huongg merged commit 73ac8b0 into main Jul 24, 2024
12 checks passed
@Huongg Huongg deleted the refactor-command-copier branch July 24, 2024 13:21
@SajidAlamQB SajidAlamQB mentioned this pull request Jul 25, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor front-end component Command Copier
3 participants