-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace toposort with graphlib #1942
Conversation
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
…edro-org/kedro-viz into replace-toposort-with-graphlib Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and the tests are all passing.
So Toposort performs several tasks under the hood, such as determining the layer and parent layer relationships. But, with graphlib, we must explicitly ensure that we don't add a layer as its own parent. Interesting.
Hi @SajidAlamQB , Nicely done. I was testing the PR and I see there is a minor issue in the UI. The order of layers is shifted - Layers feature and model_input are shifted. Even the DAG has Before After |
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Hey @ravi-kumar-pilla, this should be fixed now let me know if its all fine. |
Hi @SajidAlamQB , I tested it now and the order looks good. Thank you for that. May I know why was the static order different or why - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! It would be nice to have this in the release note to track the changes. Thank you @SajidAlamQB
The order of layers by the |
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👏🏼
Description
Related to: #1820
This ticket aims at dropping toposort dependency in favor of built-in graphlib if possible.
Development notes
QA notes
Checklist
RELEASE.md
file