-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KED-1833] Front End for hook implementation for kedro-viz #194
Conversation
Wow, this is really fast turnaround :D I remember when chatting with @MerelTheisenQB, we thought of having the new side panel extensible with "slots" that plugins can populate through hooks. Otherwise, what would happen if there is another plugins wanting to display external links? Would it be another tooltip? |
I think the best way forward is to have a behaviour based hooks. ie have |
Hi everyone! We've appreciated the careful thought that went into this PR. However, I'm going to close this PR on the basis that when we look into the Kedro-GE integration, we'll pick up this work again. I also note that at least this information is stored somewhere. |
Description
This PR adds FE changes to Hook implementation for kedro-viz
Development notes
Some code in
package/kedro_viz/server.py
,package/kedro_viz/specs.py
andpackage/tests/test_server.py
is from the aforementioned PR.Please ignore the styling for now.
Updated:
QA notes
Checklist
RELEASE.md
fileLegal notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.