Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-1833] Front End for hook implementation for kedro-viz #194

Closed
wants to merge 14 commits into from
Closed

[KED-1833] Front End for hook implementation for kedro-viz #194

wants to merge 14 commits into from

Conversation

ptadas
Copy link

@ptadas ptadas commented Jun 15, 2020

Description

This PR adds FE changes to Hook implementation for kedro-viz

Development notes

Some code in package/kedro_viz/server.py, package/kedro_viz/specs.py and package/tests/test_server.py is from the aforementioned PR.

Please ignore the styling for now.

Jun-15-2020 15-02-34

Updated:

  • Change the node color (can be some other indicator) whenever a hook for a dataset exists
  • When right click on the node, replace the default context menu, with the one for hooks (at this point not entirely sure what other hooks will exist, thus assume all will have same functionality)

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Legal notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@ptadas ptadas changed the title Ge fe Front End for hook implementation for kedro-viz Jun 15, 2020
@ptadas ptadas marked this pull request as ready for review June 15, 2020 14:06
@ptadas ptadas marked this pull request as draft June 15, 2020 14:07
@limdauto
Copy link
Collaborator

Wow, this is really fast turnaround :D I remember when chatting with @MerelTheisenQB, we thought of having the new side panel extensible with "slots" that plugins can populate through hooks. Otherwise, what would happen if there is another plugins wanting to display external links? Would it be another tooltip?

@ptadas
Copy link
Author

ptadas commented Jun 16, 2020

Wow, this is really fast turnaround :D I remember when chatting with @MerelTheisenQB, we thought of having the new side panel extensible with "slots" that plugins can populate through hooks. Otherwise, what would happen if there is another plugins wanting to display external links? Would it be another tooltip?

I think the best way forward is to have a behaviour based hooks. ie have kedro-ge add data to node['hooks']['context_menu'] + maybe additional behaviour options within the hook, ie node['hooks']['context_menu']['href'], but open to suggestions! I guess we don't need to overcomplicate the nested structure for the first hooks, as we can always update when new hooks get added

@921kiyo 921kiyo changed the title Front End for hook implementation for kedro-viz [KED-1833] Front End for hook implementation for kedro-viz Jun 30, 2020
@yetudada
Copy link
Contributor

Hi everyone! We've appreciated the careful thought that went into this PR. However, I'm going to close this PR on the basis that when we look into the Kedro-GE integration, we'll pick up this work again. I also note that at least this information is stored somewhere.

@yetudada yetudada closed this Jul 13, 2020
@daBlesr daBlesr mentioned this pull request Apr 28, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants