Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch _transcoding to transcoding #1926

Closed
wants to merge 1 commit into from
Closed

Switch _transcoding to transcoding #1926

wants to merge 1 commit into from

Conversation

ankatiyar
Copy link
Contributor

@ankatiyar ankatiyar commented May 23, 2024

Description

I noticed the kedro-viz was throwing deprecation warnings for TRANSCODING_SEPARATOR when trying it with Kedro from the main branch - This is due to this PR kedro-org/kedro#3826 This change will be released in Kedro 0.19.6

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@rashidakanchwala
Copy link
Contributor

thank you so much. You are a ⭐ @ankatiyar

Copy link
Contributor

@Huongg Huongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ankatiyar 👍

@rashidakanchwala
Copy link
Contributor

I think this will not work with Kedro 0.19.4 and 0.19.5. Let's discuss @ankatiyar

@ankatiyar
Copy link
Contributor Author

Closing this in favour of #1928 as discussed offline with @rashidakanchwala

@ankatiyar ankatiyar closed this May 29, 2024
@ankatiyar ankatiyar deleted the transcoding branch May 29, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants