Fix Kedro Viz stays waiting even if no valid project was found #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashidakanchwala
changed the title
| from kedro_viz.server import run_server | ||
|
|
||
| project_path = Path.cwd() | ||
|
|
||
| bootstrap_project(project_path) |
There was a problem hiding this comment.
This is fine but instead of showing an error stack trace, it would be nice to show a custom error message with the exception, something like -
# check if the project_path points to a valid Kedro Project
try:
bootstrap_project(project_path)
except Exception as exc:
display_cli_message(f"ERROR: Unable to start Kedro-Viz : {exc} ", "red")
return| @@ -158,7 +164,6 @@ def run( | |||
| "extra_params": params, | |||
| } | |||
| if autoreload: | |||
| project_path = Path.cwd() | |||
| run_server_kwargs["project_path"] = project_path | |||
| run_process_kwargs = { | |||
| "path": project_path, | |||
There was a problem hiding this comment.
The above process calls run_server -> load_and_populate_data -> load_data . In load_data we again call bootstrap_project (line 91) which is a duplicate call. Though I like the idea of having bootstrap_project inside data_loader which makes sense considering it loads metadata, we need to remove this if we go by the approach in this PR. For the dev mode we already have bootstrap_project(project_path) in server.py -> main at line 143
|
closing this for now. will work on this from #1796 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1761
Development notes
Before we start running any of the viz processing, we first call the
bootstrap_project(project_path)fromkedro.framework.startupto ensure that we are runningkedro vizrun from a valid kedro project.QA notes
Checklist
RELEASE.mdfile