Implementation of Directory Selection for Server Startup [Santana's PR] #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
| @@ -56,6 +56,12 @@ def viz(ctx): | |||
| default=DEFAULT_HOST, | |||
| help="Host that viz will listen to. Defaults to localhost.", | |||
| ) | |||
| @click.option( | |||
| "--project_path", | |||
There was a problem hiding this comment.
for consistency the option can be renamed to - --project-path
| @@ -137,9 +137,14 @@ def run_server( | |||
| parser.add_argument( | |||
| "--port", help="The port of the development server", default=DEV_PORT | |||
| ) | |||
| parser.add_argument("--project_path", help="Path to a Kedro project") | |||
There was a problem hiding this comment.
can be renamed to --project-path for consistency
| @@ -158,7 +166,7 @@ def run( | |||
| "extra_params": params, | |||
| } | |||
| if autoreload: | |||
| project_path = Path.cwd() | |||
| project_path = Path(project_path) if project_path else Path.cwd() | |||
There was a problem hiding this comment.
run_server also does Path(project_path) if project_path else Path.cwd() on line 109 server.py, so we can just pass project_path and this is not needed
|
Closing this one as I was able to create a PR based off contributor PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is based on Santana's work #1741. I was not able to work off that ticket since it was forked, so created a new PR.
Development notes
QA notes
Checklist
RELEASE.mdfile