Fix kedro run on demo-project
#1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravi-kumar-pilla
approved these changes
Feb 29, 2024
|
Awesome !! Thanks @ankatiyar and @rashidakanchwala |
ankatiyar
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Kedro CLI has undergone some modifications, leading to inconsistencies with our demo-project's cli.py file. Upon investigation, @ankatiyar discovered that this issue was because of outdated code within cli.py i.e.
package_nameargument forKedroSession.create().@ankatiyar recommended removing
cli.pyfile and it made sense because I am not sure why we had the file in the first place and removing it does not break anything.Development notes
QA notes
Checklist
RELEASE.mdfile