-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for all Bugbash 8.0.0 findings #1767
Conversation
Signed-off-by: ravi-kumar-pilla <[email protected]>
Important doc note added under experiment tracking doc. |
…x/bugbash-8.0.0 Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: <>
…o-viz into fix/bugbash-8.0.0 Signed-off-by: <>
Signed-off-by: ravi-kumar-pilla <[email protected]>
…o-viz into fix/bugbash-8.0.0 Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Hi @stephkaiser, Since there is a breaking change with kedro-datasets 2.1.0 for Kedro-Viz, we are showing the below banner for experiment-tracking on all the panels (Overview, Metrics, Plots) from Kedro-Viz versions 8.0.0 and above if the user has kedro-datasets version < 2.1.0. Please let us know if the banner looks fine from design perspective. Thank you cc: @jitu5 thanks for the banner ! |
Signed-off-by: ravi-kumar-pilla <[email protected]>
Not sure, if it needs to be yellow, but I will let Steph comment. Can it say kedro-datasets = 2.1.0 |
Signed-off-by: <>
@rashidakanchwala Updated kedro-datasets version number to 2.1.0 in banner and important docs note. |
Signed-off-by: <> # Conflicts: # src/components/shareable-url-modal/shareable-url-modal.js
|
@stephkaiser Please review and let me know if it needs any more changes. |
Signed-off-by: <>
Thank you @jitu5 the padding/spacing of the banner text looks good to me! I just noticed the font size is slightly bigger, can we make sure its the same font size as the text below and the Overview/Metrics/Plots tab labels? |
Signed-off-by: <>
Signed-off-by: <>
@stephkaiser Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @ravi-kumar-pilla
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ravi-kumar-pilla LGTM from a backend standpoint.
Description
As per title
Development notes
Starting from version 8.0.0 of Kedro-Viz, Experiment Tracking is exclusively supported for users with kedro-datasets version 2.1 or higher.
kedro viz deploy
command when bucket is not available in case of AzureQA notes
Checklist
RELEASE.md
file