Add tooltip to shareable urls copy button #1614
Conversation
…osition Signed-off-by: Vladimir <[email protected]>
There was a problem hiding this comment.
The output of this is looking good. We need to make sure that this implementation is changed across the app though, as it says in #1555:
implement the new component globally across the kedro-viz tool.
Can you please implement this for the command copier in the metadata panel?
Signed-off-by: Vladimir <[email protected]>
There was a problem hiding this comment.
Looking good. One small comment about the padding being a little bit off.
Also seeing some new deprecation warnings in the terminal when running npm start:
Lastly, and you don't need to do this in this PR: I try to advocate for sorting CSS and React properties in alphabetical order so it's easier for other devs to work through the codebase.
| position: relative; | ||
| width: max-content; | ||
| max-width: calc(50vw - 150px); | ||
| padding: 12px 20px; |
There was a problem hiding this comment.
Looking at the design, I think these values are off a little bit:
There was a problem hiding this comment.
Oh I see the warning now. It's there only for a moment and I didn't see it.
I do agree sorting React props makes sense but it doesn't for css props. It would be easier to read if the are sorted by display, layout, appearance and text props.
Potentially we can add a script that auto-sorts the css props for us by given rules.
Signed-off-by: Vladimir <[email protected]>
|
Can we one line to the release notes about this as well? |
Signed-off-by: Vladimir <[email protected]>
This is minor release with big backend refactoring work and some bug fixes. Bug fixes and other changes Refactor flowchart dataclasses to pydantic base models. (Refactor Flowchart models from dataclass to pydantic base models #1565) Fix dataset factory patterns in Experiment Tracking. (Fix dataset factory patterns in Experiment Tracking #1588) Update demo-project to use OmegaConfigLoader. (Update demo project to use OmegaConfigLoader #1590) Improve feedback for copy to clipboard feature. (Add tooltip to shareable urls copy button #1614) Ensure Kedro-Viz works when hosted on a URL subpath. (Fix: Kedro-Viz doesn't work when hosted via a URL subpath #1621) Bump fastapi upper bounds. (Bump FAST API upper bounds #1634) Fix shareable URL modal to appear across the app. (Make shareable URL modal open globally across the app. #1639) Add Kedro-Viz CLI command deprecation warning. (Add kedro viz deprecation warning for CLI #1641)
Description
Updates to tooltip component and adding it copy to clipboard and displaying it as feedback.
Resolves #1555
Development notes
QA notes
This can be tested by following the instructions from this PR and clicking the copy button after creating the url.
A quick and dirty way of testing - go to shareable-url-modal component and comment all the html except the url result form and click the button.
Checklist
RELEASE.mdfile