Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Setting Env. Variable for cross platform #1563

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fix: Setting Env. Variable for cross platform #1563

merged 1 commit into from
Oct 10, 2023

Conversation

jitu5
Copy link
Contributor

@jitu5 jitu5 commented Oct 9, 2023

Description

It resolves issue in The Circle CI build for change related to #1534

Development notes

Cross-env package added to make sure env. variable is being set for all the platform correctly.

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@jitu5 jitu5 added the Javascript Pull requests that update Javascript code label Oct 9, 2023
@jitu5 jitu5 self-assigned this Oct 9, 2023
@jitu5 jitu5 requested a review from tynandebold as a code owner October 9, 2023 09:07
ravi-kumar-pilla
ravi-kumar-pilla approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 👍 . LGTM

tynandebold
tynandebold approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@tynandebold tynandebold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one.

@tynandebold tynandebold merged commit cb07ab3 into main Oct 10, 2023
2 checks passed
@tynandebold tynandebold deleted the fix/cross_env branch October 10, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravi-kumar-pilla ravi-kumar-pilla ravi-kumar-pilla approved these changes

@tynandebold tynandebold tynandebold approved these changes

@rashidakanchwala rashidakanchwala Awaiting requested review from rashidakanchwala rashidakanchwala is a code owner

Assignees

@jitu5 jitu5

Labels
Javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jitu5 @tynandebold @ravi-kumar-pilla