Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows builds #1171

Merged
merged 10 commits into from
Nov 18, 2022
Merged

Fix windows builds #1171

merged 10 commits into from
Nov 18, 2022

Conversation

tynandebold
Copy link
Member

@tynandebold tynandebold commented Nov 17, 2022 •
edited
Loading

Signed-off-by: Tynan DeBold [email protected]

Description

The tests were failing again.

Development notes

I don't actually install NVM now, I just use it during the Windows builds, and it seems to work fine. Here's a successful run.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@tynandebold
Try to fix windows builds
2de8c0b 
Signed-off-by: Tynan DeBold <[email protected]>
@tynandebold
Avoid the node/install part of the process
b830fba 
Signed-off-by: Tynan DeBold <[email protected]>
@tynandebold
Check node version in npm_build step
ff2eaaa 
Signed-off-by: Tynan DeBold <[email protected]>
@tynandebold
Revert to install_node_dependencies to check error
bf13d29 
Signed-off-by: Tynan DeBold <[email protected]>
@tynandebold
Run npm install without installing node
3678f9e 
Signed-off-by: Tynan DeBold <[email protected]>
@tynandebold
Run npm install without installing node with correct indent
059daba 
Signed-off-by: Tynan DeBold <[email protected]>
@tynandebold
Use nvm for all installs
97c5ed5 
Signed-off-by: Tynan DeBold <[email protected]>
@tynandebold
Run nvm_use_npm_install for windows builds only
fe65d93 
Signed-off-by: Tynan DeBold <[email protected]>
@tynandebold
Seems to work, so revert filters and branch-specific triggers
7a6b156 
Signed-off-by: Tynan DeBold <[email protected]>
@tynandebold
Remove unused command
216632a 
Signed-off-by: Tynan DeBold <[email protected]>
@tynandebold tynandebold marked this pull request as ready for review November 18, 2022 10:28
@tynandebold tynandebold merged commit 9b50f29 into main Nov 18, 2022
@tynandebold tynandebold deleted the chore/windows-build-failure-fix branch November 18, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

@cvetankanechevska cvetankanechevska cvetankanechevska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tynandebold @rashidakanchwala @cvetankanechevska