Feature/url parameters

[Huongg]

Description

Fixes #1117

I use Query parameters rather than URI parameters, hence all of them are combined into a single string as below

main: '/',
focusedNode: `/?${pipelineActive}&${params.focused}:id`,
selectedNode: `/?${pipelineActive}&${params.selected}:id`,

As discussed with the engineer and design team, the URL parameter should cover a few scenarios, such as

• when selecting/clicking on a single node , the URL will includeselected_id:...
• it also recognises whether the node belongs to a modular pipeline or not, if it does then expand the modular pipeline list
• when focusing on a modular pipeline the URL will include focused_id:...
• we don't update the parameter when switching between different pipeline views but we do include the view in the URL parameter when the user performs an action. eg ?pipeline_id=Modelling%20stage&selected_id=cae2d1c7
• it also works when you click on the flowchart

Development notes

QA notes

Checklist

• Read the contributing guidelines
• Opened this PR as a 'Draft Pull Request' if it is work-in-progress
• Updated the documentation to reflect the code changes
• Added new entries to the RELEASE.md file
• Added tests to cover my changes

[tynandebold]

That error message is looking really good! Well done.

Why does the page crash with an incorrect pipeline ID but not an incorrect node ID? In any event, I think how you handled that before in your previous linked commit can work. The main thing is that the app doesn't crash like in your third screenshot above.

[Huongg]

That error message is looking really good! Well done.

Why does the page crash with an incorrect pipeline ID but not an incorrect node ID? In any event, I think how you handled that before in your previous linked commit can work. The main thing is that the app doesn't crash like in your third screenshot above.

hey sounds good, I've gone back to how I did it before, the error messages should now cover all cases, incl invalid pipeline ID

[tynandebold]

Amazing! Approved. Great work on this one, Huong. Thanks so much for seeing it through.

I have one worry that some of the URL params we're adding may potentially mess with some of the jupyter-server-proxy stuff @AntonyMilneQB worked on that I helped him with, though it's hard to tell right now. I don't remember how to test that at the moment, so I think for now it'll have to be ok!

[tynandebold]

Is it too much of a pain to pass these props to the same component on line 66? I guess there might be some other work to do it you put it there and don't have this if / else.

[Huongg]

hey the reason I separate them with if/else statements so it won't render the Flowchart + any other things, cause other wise the flowchart will still show up in the background

[rashidakanchwala]

Hi @Huongg --- looks' greatt!! <3

i just came across another error handling issue, when we type something incorrect in the focus mode then it's a blank screen.

try http://localhost:4141/?pipeline_id=__default__&focused_id=featured_engineering instead of http://localhost:4141/?pipeline_id=__default__&focused_id=feature_engineering

[Huongg]

Hi @Huongg --- looks' greatt!! <3

i just came across another error handling issue, when we type something incorrect in the focus mode then it's a blank screen.

try http://localhost:4141/?pipeline_id=__default__&focused_id=featured_engineering instead of http://localhost:4141/?pipeline_id=__default__&focused_id=feature_engineering

hey @rashidakanchwala sorry i didnt push my latest changes to it, it should be fixed now with the invalid Modular Pipeline

[rashidakanchwala]

Thanks @Huongg .. super excited abt this feature release :)

[Huongg]

I've updated the copy for the error message suggested by @stichbury. @comym @Mackay031 if you're happy can i get approval for this PR please?