-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in text for users to reboot their Kedro-Viz after using the expandAllPipelines
flag
#792
Comments
In the settings panel, the toggle for |
Unfortunately this cannot be applied to the There is also another quick solution, which is to add the wording That said, I do agree with design that having a 'Apply Changes' button for the settings panel provides more clarity and assurance of applying the settings, especially given the panel is a modal - I will have a quick chat with design and we can decide on a the best solution. |
update: as per discussion in our team sprint planning, we will go for the quick win solution of modifying the description, and later on to implement the |
expandAllPipelines
flag
Closed with completion of #875. |
Description
The current settings panel does not have a 'Apply' button where settings are applied immediately on toggling the settings. However, the setup of some feature flags is designed to be implement on load, such as the
sizeWarning
and the newly introducedexpandAllPipelines
flags, which causes general confusion as toggling the settings on the settings panel would not cause the settings to be immediately reflected until the next refresh of the page.Generally it is confusing for the user to confirm on whether the settings have been applied without the 'Apply and Close' button.
This is to report the need to implement a 'Apply' button for the panel to solve the need to reload the app on updating feature flag settings ( the button is present in the design for the settings panel here, QB access only)
Context
Without the button, updating the feature flag settings would not allow the relevant features to be reflected until the app reloads.
Expected Result
A 'Apply and Close' button should be present, where on pressing the button it allows the app to reload and apply the behaviour introduced by the feature flags.
Actual Result
Currently, toggling the feature flag would not cause immediate effect until the user refreshs the app.
Checklist
The text was updated successfully, but these errors were encountered: