Feature/better apply and close ux #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Tynan DeBold <[email protected]>
…ature/better-apply-and-close-ux Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Tynan DeBold <[email protected]>
|
I like it, I feel it's working well! That's not ready for shipping though. The tick mark you have included after the text is not according to the design and it should be changed to the emoji as seen on the provided assets on Figma. Many thanks.
|
rashidakanchwala
approved these changes
Jun 1, 2022
…ature/better-apply-and-close-ux Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Tynan DeBold <[email protected]>
@GabrielComymQB thanks for this. As discussed just now on our call, I've added the ✅ instead of the 😎 one. If there's nothing else to change, feel free to approve the PR whenever you can. Thanks so much. |
comym
approved these changes
Jun 1, 2022
This was referenced Jun 8, 2022
cvetankanechevska
pushed a commit
that referenced
this pull request
Jun 9, 2022
* add and update buttons across modals; wire up some of the functionality Signed-off-by: Tynan DeBold <[email protected]> * remove X icon; update styles so we can transition them Signed-off-by: Tynan DeBold <[email protected]> * experiment tracking modal looking good with the animations Signed-off-by: Tynan DeBold <[email protected]> * update fn names and tests Signed-off-by: Tynan DeBold <[email protected]> * tests Signed-off-by: Tynan DeBold <[email protected]> * update release notes Signed-off-by: Tynan DeBold <[email protected]> * add check mark emoji Signed-off-by: Tynan DeBold <[email protected]> Signed-off-by: Cvetanka <[email protected]>
This was referenced Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #860.
Development notes
The heft of this is in the
Modalfiles. I added some state to be able to track what's been clicked, and then the different button text and styles act on that.I thought about refactoring the actual
Modalcomponent and decided against it. I think it would be a premature optimization.QA notes
Here's what it looks like:
Screen.Recording.2022-05-30.at.17.30.06.mov
Take a look at the branch via Gitpod and play around with it.
Note: in the button's success state I've used a check mark (✓) instead of the emoji (😎). I found this to be a good middle ground between playful and showy.
Checklist
RELEASE.mdfile