Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Kedro-viz experience on notebooks. #1668

Closed
1 task
rashidakanchwala opened this issue Dec 4, 2023 · 1 comment · Fixed by #1722
Closed
1 task

Improve Kedro-viz experience on notebooks. #1668

rashidakanchwala opened this issue Dec 4, 2023 · 1 comment · Fixed by #1722
Assignees
Labels
Issue: Feature Request Python Pull requests that update Python code Quick Win Low/Medium priorities but quick to do

Comments

@rashidakanchwala
Copy link
Contributor

Description

When using the %run_viz command for kedro-viz in Jupyter notebooks, it currently opens as an embedded iframe, which is not ideal. The goal of this ticket is to enhance the user experience by adopting a Databricks-like approach, where instead a link is displayed. Clicking this link will open Kedro-viz in a new browser tab.

Screenshot 2023-12-04 at 12 54 38

Possible Implementation

Here's an example of how it works in Databricks https://docs.kedro.org/en/latest/deployment/databricks/databricks_visualisation.html

Possible Alternatives

(Optional) Describe any alternative solutions or features you've considered.

Checklist

  • Include labels so that we can categorise your feature request
@rashidakanchwala rashidakanchwala moved this to Inbox in Kedro-Viz Dec 4, 2023
@rashidakanchwala rashidakanchwala added the Python Pull requests that update Python code label Dec 4, 2023
@rashidakanchwala rashidakanchwala moved this from Inbox to Backlog in Kedro-Viz Dec 4, 2023
@astrojuanlu
Copy link
Member

For complex iframes, jupyterlab-contrib/rise allows the user to open the page on a new tab (when on Notebook) or seeing the page in a separate panel:

jupyter-rise

For simpler interactions, it's possible to embed them in the notebook itself, similar to scikit-learn pipelines or ipyleaflet:

Screenshot 2023-12-04 at 18-32-18 Untitled

Given that Viz can be used as a React component, maybe it's something worth looking into.

(Also for any experiments, make sure you're using Notebook>=7, which is based on JupyterLab 4)

@rashidakanchwala rashidakanchwala moved this from Backlog to Todo in Kedro-Viz Dec 11, 2023
@rashidakanchwala rashidakanchwala moved this from Todo to Backlog in Kedro-Viz Jan 8, 2024
@rashidakanchwala rashidakanchwala added the Quick Win Low/Medium priorities but quick to do label Jan 16, 2024
@SajidAlamQB SajidAlamQB self-assigned this Jan 22, 2024
@rashidakanchwala rashidakanchwala moved this from Backlog to Todo in Kedro-Viz Jan 22, 2024
@SajidAlamQB SajidAlamQB moved this from Todo to In Progress in Kedro-Viz Jan 29, 2024
@SajidAlamQB SajidAlamQB linked a pull request Jan 30, 2024 that will close this issue
5 tasks
@SajidAlamQB SajidAlamQB moved this from In Progress to In Review in Kedro-Viz Jan 30, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request Python Pull requests that update Python code Quick Win Low/Medium priorities but quick to do
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants