-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Kedro-viz experience on notebooks #1722
Conversation
Signed-off-by: Sajid Alam <[email protected]>
I notice in the screenshot that you're using an old version of Jupyter notebook, @SajidAlamQB could you try with |
Here is what it looks like with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look's great. Thanks Sajid! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Should this change be included in the release notes?
Signed-off-by: Sajid Alam <[email protected]>
* Add link to open in new tab * add test and lint Signed-off-by: Sajid Alam <[email protected]> * Update RELEASE.md Signed-off-by: Sajid Alam <[email protected]> --------- Signed-off-by: Sajid Alam <[email protected]> Signed-off-by: Elias Santana <[email protected]>
Description
When using the
%run_viz
command forkedro-viz
in Jupyter notebooks, it should open Kedro-viz in a new browser tab.Development notes
When clicking
Open Kedro-Viz
a new tab is opened:QA notes
Added one new unit tests that checks the target attribute is set
to _blank
, and the link text isOpen Kedro-Viz
.Checklist
RELEASE.md
file