Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Pipeline Name in kedro-viz Run Command #1548

Closed
1 task done
drlight0715 opened this issue Oct 2, 2023 · 1 comment · Fixed by #1569
Closed
1 task done

Missing Pipeline Name in kedro-viz Run Command #1548

drlight0715 opened this issue Oct 2, 2023 · 1 comment · Fixed by #1569
Assignees
Labels
Issue: Bug Report Quick Win Low/Medium priorities but quick to do

Comments

@drlight0715
Copy link

drlight0715 commented Oct 2, 2023

Description

Pipeline names are not displayed in visuals created by kedro-viz.

Context

I aim to display a pipeline name in Run Command section.

Steps to Reproduce

  1. Set up a kedro pipeline
  2. Run kedro viz

Expected Result

A pipeline name should be visible in Run Command.

Actual Result

No pipeline name is displayed in Run Command.

image

Your Environment

Include as many relevant details as possible about the environment you experienced the bug in:

  • Web browser system and version: Google Chrome
  • Operating system and version: Mac OS Ventura 13.6
  • NodeJS version used (if relevant):
  • Kedro version used (if relevant): 0.18.13
  • Python version used (if relevant): 3.9.13

Checklist

  • Include labels so that we can categorise your issue
@rashidakanchwala
Copy link
Contributor

rashidakanchwala commented Oct 2, 2023

I was able to recreate this bug at my end using the demo_project code.

Steps to Reproduce

  • in demo_project/pipelines/modelling/pipeline.py add 'name' to the split_data function so it will be like below
  split_stage_pipeline = pipeline(
        [
            node(
                func=split_data,
                inputs=["model_input_table", "params:split_options"],
                outputs=test_train_refs,
                name='split_data'
            )
        ]
    )

next if you run kedro_viz and click on the split_data function - you should see this.

Screenshot 2023-10-02 at 10 26 21

Expected Result -

There should be no None. It should just say kedro run --to-nodes=split_data

@rashidakanchwala rashidakanchwala moved this to Inbox in Kedro-Viz Oct 2, 2023
@tynandebold tynandebold added the Quick Win Low/Medium priorities but quick to do label Oct 10, 2023
@tynandebold tynandebold moved this from Inbox to Backlog in Kedro-Viz Oct 10, 2023
@MehdiNV MehdiNV self-assigned this Oct 11, 2023
@MehdiNV MehdiNV moved this from Backlog to In Progress in Kedro-Viz Oct 11, 2023
@MehdiNV MehdiNV moved this from In Progress to In Review in Kedro-Viz Oct 11, 2023
MehdiNV added a commit that referenced this issue Oct 12, 2023
* Add conditional statement, prevent None values being added automatically

Signed-off-by: mehdinv <[email protected]>

* Added new test for task_nodes w/ no namespace

Signed-off-by: mehdinv <[email protected]>

* Updated Release.md file with bug fix mention

Signed-off-by: mehdinv <[email protected]>

* Update RELEASE.md w/ PR number instead of Issue

Co-authored-by: Tynan DeBold <[email protected]>

---------

Signed-off-by: mehdinv <[email protected]>
Co-authored-by: Tynan DeBold <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report Quick Win Low/Medium priorities but quick to do
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants