Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Kedro-Viz work with kedro-datasets #1205

Closed
merelcht opened this issue Dec 21, 2022 · 2 comments · Fixed by #1214
Closed

Make Kedro-Viz work with kedro-datasets #1205

merelcht opened this issue Dec 21, 2022 · 2 comments · Fixed by #1214
Assignees
Labels
Python Pull requests that update Python code

Comments

@merelcht
Copy link
Member

Description

From Kedro 0.18.4 we’re using datasets from kedro-datasets and so the import paths are different. kedro_datasets.plotly.PlotlyDataSet instead of kedro.extras.datasets.plotly.plotly_dataset.PlotlyDataSet etc. If a user is using Kedro 0.18.4 with kedro-datasets viz doesn't detect plot datasets correctly, experiment tracking doesn't work and other things where paths have been hard-coded in viz.

Context

We need to make Kedro viz support kedro-datasets and keep it compatible with using datasets from Kedro itself at least for the 5.x series. Perhaps in 6.0 we’d want to remove compatibility with datasets inside kedro

@tynandebold
Copy link
Member

tynandebold commented Jan 9, 2023

This ticket will focus on fixing this specific issue in a way that isn't too generic.

Related ticket: #963

@stichbury
Copy link
Contributor

Please can you let me know when you complete this ticket? We will need to update the documentation to remove the dependency on Kedro 0.18.3 and datasets that I included on the page to ensure it all worked correctly. Please can you either do that or let me know so I can do it. We just need to test that the documented example now works as expected against the very latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python Pull requests that update Python code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants