-
Notifications
You must be signed in to change notification settings - Fork 113
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Description Resolves #805. Development notes Ok so the main things done in this PR:- Added support for the earliest Kedro version that Kedro-viz supports, which is Kedro 0.17.5. The end-to-end (e2e) tests for Kedro 0.17.5 will skip if the Python version is greater than 3.8, as Kedro 18 only works with Python 3.9 and above. Removed old code related to Kedro 0.16.0 in environment.py, which involved unnecessary package installations. Implemented a suggestion by @tynandebold to capture Kedro-viz breaking due to old dependencies in our end-to-end (e2e) tests. I created a lower-bound requirements.txt file for testing Kedro-viz functionality. If the tests fail, we know that we need to increase the lower-bound on our dependencies. Added an additional assert statement to check if kedro-viz is running, as the viz flowchart for Kedro 0.17.5 and Kedro 0.18 are different. Removed win-e2e-test for Python 3.7 since it was failing. Since we plan to drop support for Python 3.7 soon, we decided not to spend time investigating the issue. also thanks @astrojuanlu for help on this ticket :)
- Loading branch information
1 parent
62c9aa0
commit f635564
Showing
8 changed files
with
91 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
semver==3.0 | ||
ipython==7.0.0 | ||
fastapi==0.73.0 | ||
fsspec==2021.4 | ||
aiofiles==22.1.0 | ||
uvicorn[standard]==0.22.0 | ||
watchgod==0.8.2 | ||
plotly==4.0 | ||
pandas==1.3; python_version < '3.10' | ||
pandas==1.4; python_version >= '3.10' | ||
sqlalchemy==1.4 | ||
strawberry-graphql==0.192.0 | ||
networkx==2.5 | ||
orjson==3.9 | ||
secure==0.3.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters