-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(docker): Update error code on e2e tests #813
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
ankatiyar
changed the title
ci(docker): Update error message on e2e tests
ci(docker): Update error code on e2e tests
Aug 27, 2024
ElenaKhaustova
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ankatiyar!
merelcht
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ankatiyar !! ⭐
7 tasks
harm-matthias-harms
pushed a commit
to harm-matthias-harms/kedro-plugins
that referenced
this pull request
Oct 1, 2024
* Update error message docker Signed-off-by: Ankita Katiyar <[email protected]> * typo Signed-off-by: Ankita Katiyar <[email protected]> * Update step Signed-off-by: Ankita Katiyar <[email protected]> * Change exit code Signed-off-by: Ankita Katiyar <[email protected]> * Error message Signed-off-by: Ankita Katiyar <[email protected]> --------- Signed-off-by: Ankita Katiyar <[email protected]> Signed-off-by: Harm Matthias Harms <[email protected]>
MinuraPunchihewa
pushed a commit
to MinuraPunchihewa/kedro-plugins
that referenced
this pull request
Oct 1, 2024
* Update error message docker Signed-off-by: Ankita Katiyar <[email protected]> * typo Signed-off-by: Ankita Katiyar <[email protected]> * Update step Signed-off-by: Ankita Katiyar <[email protected]> * Change exit code Signed-off-by: Ankita Katiyar <[email protected]> * Error message Signed-off-by: Ankita Katiyar <[email protected]> --------- Signed-off-by: Ankita Katiyar <[email protected]> Signed-off-by: Minura Punchihewa <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #800
Development notes
Kedro doesn't return an error exit code anymore I think because of this PR kedro-org/kedro#4075. Not sure if this was intentional cc @lrcouto
Checklist
RELEASE.md
file