Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(docker): Update error code on e2e tests #813

Merged
merged 6 commits into from
Aug 27, 2024
Merged

ci(docker): Update error code on e2e tests #813

merged 6 commits into from
Aug 27, 2024

Conversation

ankatiyar
Copy link
Contributor

@ankatiyar ankatiyar commented Aug 22, 2024

Description

Fix #800

Development notes

Kedro doesn't return an error exit code anymore I think because of this PR kedro-org/kedro#4075. Not sure if this was intentional cc @lrcouto

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

ankatiyar and others added 6 commits August 22, 2024 16:48
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
@ankatiyar ankatiyar marked this pull request as ready for review August 27, 2024 14:04
@ankatiyar ankatiyar changed the title ci(docker): Update error message on e2e tests ci(docker): Update error code on e2e tests Aug 27, 2024
Copy link
Contributor

@ElenaKhaustova ElenaKhaustova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ankatiyar!

Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ankatiyar !! ⭐

@ankatiyar ankatiyar merged commit 1eb2bf7 into main Aug 27, 2024
22 checks passed
@ankatiyar ankatiyar deleted the ci-stuff-docker branch August 27, 2024 14:35
harm-matthias-harms pushed a commit to harm-matthias-harms/kedro-plugins that referenced this pull request Oct 1, 2024
* Update error message docker

Signed-off-by: Ankita Katiyar <[email protected]>

* typo

Signed-off-by: Ankita Katiyar <[email protected]>

* Update step

Signed-off-by: Ankita Katiyar <[email protected]>

* Change exit code

Signed-off-by: Ankita Katiyar <[email protected]>

* Error message

Signed-off-by: Ankita Katiyar <[email protected]>

---------

Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Harm Matthias Harms <[email protected]>
MinuraPunchihewa pushed a commit to MinuraPunchihewa/kedro-plugins that referenced this pull request Oct 1, 2024
* Update error message docker

Signed-off-by: Ankita Katiyar <[email protected]>

* typo

Signed-off-by: Ankita Katiyar <[email protected]>

* Update step

Signed-off-by: Ankita Katiyar <[email protected]>

* Change exit code

Signed-off-by: Ankita Katiyar <[email protected]>

* Error message

Signed-off-by: Ankita Katiyar <[email protected]>

---------

Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Minura Punchihewa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kedro-docker: Nightly build failure
3 participants