Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(datasets): fix typos in definition of extras #593

Merged
merged 3 commits into from
Mar 4, 2024
Merged

build(datasets): fix typos in definition of extras #593

merged 3 commits into from
Mar 4, 2024

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Mar 2, 2024 •
edited
Loading

Description

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

deepyaman
deepyaman commented Mar 2, 2024
View reviewed changes
Copy link
Member Author

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another question I had when looking through the file: Is it intentional that the extras for pandas.GBQQueryDataset and pandas.GBQTableDataset are lumped under pandas-gbqdataset, and the same for pandas.SQLQueryDataset and pandas.SQLTableDataset being lumped under pandas-sqldataset? I couldn't find any discussion on #570 at a glance, but it seemed inconsistent with how users usually install these based on dataset name.

@deepyaman deepyaman marked this pull request as ready for review March 2, 2024 01:56
@deepyaman
Copy link
Member Author

Docs issue is unrelated, and I couldn't figure out how to resolve it at a glance.

@ankatiyar
Copy link
Contributor

Another question I had when looking through the file: Is it intentional that the extras for pandas.GBQQueryDataset and pandas.GBQTableDataset are lumped under pandas-gbqdataset, and the same for pandas.SQLQueryDataset and pandas.SQLTableDataset being lumped under pandas-sqldataset? I couldn't find any discussion on #570 at a glance, but it seemed inconsistent with how users usually install these based on dataset name.

No, I think I missed it while going by file names - fixed it in 16b084f

ankatiyar
ankatiyar approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deepyaman!

@ankatiyar ankatiyar requested review from astrojuanlu and lrcouto March 4, 2024 13:10
@deepyaman deepyaman enabled auto-merge (squash) March 4, 2024 14:07
astrojuanlu
astrojuanlu approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deepyaman !

@deepyaman deepyaman merged commit 565c296 into main Mar 4, 2024
12 checks passed
@deepyaman deepyaman deleted the build/datasets/fix-typos-in-extra-defs branch March 4, 2024 14:40
tgoelles pushed a commit to tgoelles/kedro-plugins that referenced this pull request Jun 6, 2024
@deepyaman @tgoelles
build(datasets): fix typos in definition of extras (kedro-org#593)
5256c83 
* build(datasets): fix typos in definition of extras

Signed-off-by: Deepyaman Datta <[email protected]>

* build(datasets): separate pandas-sqldataset and pandas-gbqdataset

Signed-off-by: Ankita Katiyar <[email protected]>

---------

Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: tgoelles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankatiyar ankatiyar ankatiyar approved these changes

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@lrcouto lrcouto Awaiting requested review from lrcouto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepyaman @ankatiyar @astrojuanlu