Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Experiment aws patching #458

Closed
wants to merge 30 commits into from
Closed

Conversation

merelcht
Copy link
Member

Description

Debug problems in #348

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

MatthiasRoels and others added 30 commits September 21, 2023 15:41
Since s3fs is switched to aiobotocore, tests started to fail with message
`'MockRawResponse' object has no attribute 'raw_headers'`. This is a bug
in aiobotocore. Using moto server does seem to resolve the issues

Signed-off-by: Matthias Roels <[email protected]>
Signed-off-by: Matthias Roels <[email protected]>
Signed-off-by: Matthias Roels <[email protected]>

Co-authored-by: Nok Lam Chan <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
…com:MatthiasRoels/kedro-plugins into build/datasets-upgrade-s3fs-to-newer-calver
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
This was referenced Dec 4, 2023
@merelcht
Copy link
Member Author

merelcht commented Dec 5, 2023

Closing in favour of #463

@merelcht merelcht closed this Dec 5, 2023
@merelcht merelcht deleted the experiment-aws-patching branch December 11, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants