Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(datasets): Release kedro-datasets 1.7.0 #326

Merged
merged 7 commits into from
Sep 1, 2023

Conversation

ankatiyar
Copy link
Contributor

Description

Release kedro-datasets 1.7.0

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

kedro-datasets/RELEASE.md Outdated Show resolved Hide resolved
@merelcht
Copy link
Member

merelcht commented Sep 1, 2023

I'm glad to see the RTD build is catching the indentation error for the polars dataset, but kind of strange it didn't flag when that was merged? 🤔 @astrojuanlu

@ankatiyar
Copy link
Contributor Author

I'm glad to see the RTD build is catching the indentation error for the polars dataset, but kind of strange it didn't flag when that was merged? 🤔 @astrojuanlu

It wasn't added to the .rst file before.

@astrojuanlu
Copy link
Member

It wasn't added to the .rst file before.

Ugh, exactly, sorry about that. Should we try to make it automatic? Or at least add a checklist item in the pull request template.

@ankatiyar
Copy link
Contributor Author

Finally fixed the docstring! Please review, @merelcht @astrojuanlu @SajidAlamQB!

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for amending the Polars docstring 🙏🏽 may I ask to cherry-pick #324 for 1.7.0?

## Community contributions
Many thanks to the following Kedroids for contributing PRs to this release:
* [Walber Moreira](https://github.com/wmoreiraa)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@ankatiyar ankatiyar merged commit e6d0f6c into main Sep 1, 2023
@ankatiyar ankatiyar deleted the release/datasets/1.7.0 branch September 1, 2023 11:47
@astrojuanlu astrojuanlu mentioned this pull request Sep 10, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants