Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Instructions on custom Airflow Operators #267

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

sbrugman
Copy link
Contributor

@sbrugman sbrugman commented Jul 12, 2023

Description

Document how to use alternative Airflow Operators. kedro-airflow should not support all operators in the current situation: apart from there being too many to keep track of, this would introduce unnecessary maintenance burden.

Being explicit about the non-goals of a project is better than leave it undocumented.

Note that these instructions remain valid if the template would be written using the TaskFlow syntax as proposed in #25.

Open for discussion of course.

Development notes

Closes #27

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 all in for small improvements

@sbrugman sbrugman changed the title Instructions on custom Airflow Operators docs: Instructions on custom Airflow Operators Jul 12, 2023
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, @sbrugman, thank you! I just suggested a small change to link to appropriate section instead of just mentioning it. Happy to approve.

kedro-airflow/README.md Outdated Show resolved Hide resolved
@ankatiyar ankatiyar added the Community Issue/PR opened by the open-source community label Jul 14, 2023
@ankatiyar
Copy link
Contributor

The DCO bot is acting up @sbrugman, could you rebase and sign-off the last commit. Sorry about this :)

@ankatiyar ankatiyar merged commit 2cad02f into kedro-org:main Jul 14, 2023
@sbrugman sbrugman deleted the patch-2 branch July 14, 2023 10:56
PtrBld pushed a commit to PtrBld/kedro-plugins that referenced this pull request Aug 27, 2023
instructions on custom Airflow Operators

Signed-off-by: Simon Brugman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Issue/PR opened by the open-source community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an additional Jinja2-Template
3 participants