Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ensure plugin requirements get installed in CI #208

Merged
merged 15 commits into from
May 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .circleci/continue_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,7 @@ commands:
command: |
cd <<parameters.plugin>>
pip install git+https://github.com/kedro-org/kedro@main
pip install .
pip install -r test_requirements.txt
pip install . -r test_requirements.txt # TODO(deepyaman): Define `test` extra and `pip install .[test]`
- run:
name: Install pre-commit hooks
command: |
Expand Down Expand Up @@ -177,7 +176,7 @@ commands:
command: conda activate kedro_plugins; pip install git+https://github.com/kedro-org/kedro@main
- run:
name: Install all requirements
command: conda activate kedro_plugins; cd <<parameters.plugin>>; pip install -r test_requirements.txt -U
command: conda activate kedro_plugins; cd <<parameters.plugin>>; pip install . -r test_requirements.txt # TODO(deepyaman): Define `test` extra and `pip install .[test]`
- run:
name: Pip freeze
command: conda activate kedro_plugins; pip freeze
Expand Down Expand Up @@ -323,7 +322,7 @@ jobs:
- run:
name: Maybe trigger the release workflow
command: |
conda activate kedro_plugins;
conda activate kedro_plugins
pip install requests
./tools/circleci/circleci_release.py

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/check-plugin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- name: Install dependencies
run: |
cd ${{ inputs.plugin }}
pip install -r test_requirements.txt
pip install . -r test_requirements.txt # TODO(deepyaman): Define `test` extra and `pip install .[test]`
- name: pip freeze
run: pip freeze
- name: Run unit tests for Linux / all plugins
Expand Down Expand Up @@ -84,7 +84,7 @@ jobs:
run: |
cd ${{ inputs.plugin }}
pip install git+https://github.com/kedro-org/kedro@main
pip install -r test_requirements.txt
pip install . -r test_requirements.txt # TODO(deepyaman): Define `test` extra and `pip install .[test]`
pip freeze
- name: Install pre-commit hooks
run: |
Expand Down Expand Up @@ -121,7 +121,7 @@ jobs:
run: |
cd ${{ inputs.plugin }}
pip install git+https://github.com/kedro-org/kedro@main
pip install -r test_requirements.txt
pip install . -r test_requirements.txt # TODO(deepyaman): Define `test` extra and `pip install .[test]`
- name: pip freeze
run: pip freeze
- name: Run end to end tests
Expand Down
14 changes: 9 additions & 5 deletions .github/workflows/kedro-airflow.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
name: Run checks on kedro-airflow
name: Run checks on Kedro-Airflow

on:
push:
paths:
- "kedro-airflow/**"
paths-ignore:
- "kedro-datasets/**"
- "kedro-docker/**"
- "kedro-telemetry/**"
pull_request:
paths:
- "kedro-airflow/**"
paths-ignore:
- "kedro-datasets/**"
- "kedro-docker/**"
- "kedro-telemetry/**"
types: [ synchronize ]

jobs:
Expand Down
14 changes: 9 additions & 5 deletions .github/workflows/kedro-datasets.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
name: Run checks on kedro-datasets
name: Run checks on Kedro-Datasets

on:
push:
paths:
- "kedro-datasets/**"
paths-ignore:
- "kedro-airflow/**"
- "kedro-docker/**"
- "kedro-telemetry/**"
pull_request:
paths:
- "kedro-datasets/**"
paths-ignore:
- "kedro-airflow/**"
- "kedro-docker/**"
- "kedro-telemetry/**"
types: [ synchronize ]

jobs:
Expand Down
14 changes: 9 additions & 5 deletions .github/workflows/kedro-docker.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
name: Run checks on kedro-docker
name: Run checks on Kedro-Docker

on:
push:
paths:
- "kedro-docker/**"
paths-ignore:
- "kedro-airflow/**"
- "kedro-datasets/**"
- "kedro-telemetry/**"
pull_request:
paths:
- "kedro-docker/**"
paths-ignore:
- "kedro-airflow/**"
- "kedro-datasets/**"
- "kedro-telemetry/**"
types: [ synchronize ]

jobs:
Expand Down
14 changes: 9 additions & 5 deletions .github/workflows/kedro-telemetry.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
name: Run checks on kedro-telemetry
name: Run checks on Kedro-Telemetry

on:
push:
paths:
- "kedro-telemetry/**"
paths-ignore:
- "kedro-airflow/**"
- "kedro-datasets/**"
- "kedro-docker/**"
pull_request:
paths:
- "kedro-telemetry/**"
paths-ignore:
- "kedro-airflow/**"
- "kedro-datasets/**"
- "kedro-docker/**"
types: [ synchronize ]

jobs:
Expand Down
2 changes: 0 additions & 2 deletions kedro-datasets/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ include = ["kedro_datasets*"]
readme = {file = "README.md", content-type = "text/markdown"}
version = {attr = "kedro_datasets.__version__"}

[tool.black]

[tool.isort]
profile = "black"

Expand Down
2 changes: 0 additions & 2 deletions kedro-docker/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ addopts = """
--no-cov-on-fail
-ra"""

[tool.black]

[tool.isort]
multi_line_output = 3
include_trailing_comma = true
Expand Down
4 changes: 1 addition & 3 deletions kedro-telemetry/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,4 @@ include_trailing_comma = true
force_grid_wrap = 0
use_parentheses = true
line_length = 88
known_third_party = "kedro"

[tool.black]
Comment on lines -46 to -47
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see why we need this empty section, but it's there on a lot of config.

known_first_party = "kedro_telemetry"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of how we're now installing the plugin itself instead of just it's requirements. Other plugins (like kedro-airflow) avoid this by using relative imports--probably by luck--but generally wouldn't prefer relative imports.

Probably needs to be a lot more consistency between team-maintained plugins on this.

Also, use of profile should be done in all the plugins.