Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Migrate the release workflow from CircleCI to GitHub Actions #203

Merged
merged 9 commits into from
May 18, 2023

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented May 11, 2023

Description

Related to: #176

Following kedro-org/kedro#2153, we also need to migrate the release workflow to GA.

Development notes

Tested on forked repo of kedro-plugins, you can find the example release workflow running here.

To fully work this, I will need the kedro-orgs pypi API key and GitHub access token and add them to the kedro-plugins repo secrets.

[17-05-23]
Here is the latest workflow running on my fork

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@SajidAlamQB SajidAlamQB self-assigned this May 11, 2023
@SajidAlamQB SajidAlamQB changed the title Migrate the release workflow from CircleCI to GitHub Actions Refactor the release workflow from CircleCI to GitHub Actions May 11, 2023
@SajidAlamQB SajidAlamQB changed the title Refactor the release workflow from CircleCI to GitHub Actions Refactor: Migrate the release workflow from CircleCI to GitHub Actions May 11, 2023
@SajidAlamQB SajidAlamQB changed the title Refactor: Migrate the release workflow from CircleCI to GitHub Actions refactor: Migrate the release workflow from CircleCI to GitHub Actions May 11, 2023
@SajidAlamQB SajidAlamQB changed the title refactor: Migrate the release workflow from CircleCI to GitHub Actions ci: Migrate the release workflow from CircleCI to GitHub Actions May 11, 2023
@ankatiyar
Copy link
Contributor

This looks good! We should add a step for running the unit tests, linters and e2e tests before publishing a release. To that end, it might be worth dividing the workflow into separate jobs like -

jobs:
  check-version: 
  (Checks if the version was updated and the new version exists on PyPi, set package_name)
  test: 
    needs: check-version
  (Reuse the `check-plugin.yml` workflow to run tests)
  build: 
    needs: check-version
  (Build only for one version of python?)
  release:
    needs: [test, build]
    steps:
      - name: GitHub release
      - name: PyPi release

check-plugin.yml currently runs all the tests on all versions of python but we can modify that in a separate PR to accept which python versions to run tests on just like it accepts plugin name from the "caller" workflow so we don't have to run all the tests 4 times.

@SajidAlamQB SajidAlamQB requested a review from noklam May 17, 2023 08:56
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ready to me! One last minor comment is usually we set ENV variable with CAPITAL letter,i.e. GITHUB_ENV.

Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯

Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments from my side, but overall this looks good 👍

.github/workflows/check-release.yml Outdated Show resolved Hide resolved
tools/github_actions/github_actions_release.py Outdated Show resolved Hide resolved
@SajidAlamQB SajidAlamQB merged commit 641c5dd into main May 18, 2023
@SajidAlamQB SajidAlamQB deleted the dev/migrate-release-workflow-to-GA branch May 18, 2023 13:18
kuriantom369 pushed a commit to tingtingQB/kedro-plugins that referenced this pull request May 30, 2023
…ro-org#203)

* Create check-release.yml

* change from test pypi to pypi

* split into jobs and move version logic into script

* update github actions output

* lint

* changes based on review

* changes based on review

* fix script to not append continuously

* change pypi api token logic

Signed-off-by: Tom Kurian <[email protected]>
noklam added a commit that referenced this pull request May 31, 2023
* Fix links on GitHub issue templates (#150)

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Tingting_Wan <[email protected]>

* add spark_stream_dataset.py

Signed-off-by: Tingting_Wan <[email protected]>

* Migrate most of `kedro-datasets` metadata to `pyproject.toml` (#161)

* Include missing requirements files in sdist

Fix gh-86.

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Migrate most project metadata to `pyproject.toml`

See kedro-org/kedro#2334.

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Move requirements to `pyproject.toml`

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

---------

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Tingting_Wan <[email protected]>

* restructure the strean dataset to align with the other spark dataset

Signed-off-by: Tingting_Wan <[email protected]>

* adding README.md for specification

Signed-off-by: Tingting_Wan <[email protected]>

* Update kedro-datasets/kedro_datasets/spark/spark_stream_dataset.py

Co-authored-by: Nok Lam Chan <[email protected]>
Signed-off-by: Tingting_Wan <[email protected]>

* rename the dataset

Signed-off-by: Tingting_Wan <[email protected]>

* resolve comments

Signed-off-by: Tingting_Wan <[email protected]>

* fix format and pylint

Signed-off-by: Tingting_Wan <[email protected]>

* Update kedro-datasets/kedro_datasets/spark/README.md

Co-authored-by: Deepyaman Datta <[email protected]>
Signed-off-by: Tingting_Wan <[email protected]>

* add unit tests and SparkStreamingDataset in init.py

Signed-off-by: Tingting_Wan <[email protected]>

* add unit tests

Signed-off-by: Tingting_Wan <[email protected]>

* update test_save

Signed-off-by: Tingting_Wan <[email protected]>

* Upgrade Polars (#171)

* Upgrade Polars

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Update Polars to 0.17.x

---------

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Tingting_Wan <[email protected]>

* if release is failed, it return exit code and fail the CI (#158)

Signed-off-by: Tingting_Wan <[email protected]>

* Migrate `kedro-airflow` to static metadata (#172)

* Migrate kedro-airflow to static metadata

See kedro-org/kedro#2334.

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Add explicit PEP 518 build requirements for kedro-datasets

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Typos

Co-authored-by: Merel Theisen <[email protected]>

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Remove dangling reference to requirements.txt

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Add release notes

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

---------

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Tingting_Wan <[email protected]>

* Migrate `kedro-telemetry` to static metadata (#174)

* Migrate kedro-telemetry to static metadata

See kedro-org/kedro#2334.

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Add release notes

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

---------

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Tingting_Wan <[email protected]>

* ci: port lint, unit test, and e2e tests to Actions (#155)

* Add unit test + lint test on GA

* trigger GA - will revert

Signed-off-by: Ankita Katiyar <[email protected]>

* Fix lint

Signed-off-by: Ankita Katiyar <[email protected]>

* Add end to end tests

* Add cache key

Signed-off-by: Ankita Katiyar <[email protected]>

* Add cache action

Signed-off-by: Ankita Katiyar <[email protected]>

* Rename workflow files

Signed-off-by: Ankita Katiyar <[email protected]>

* Lint + add comment + default bash

Signed-off-by: Ankita Katiyar <[email protected]>

* Add windows test

Signed-off-by: Ankita Katiyar <[email protected]>

* Update workflow name + revert changes to READMEs

Signed-off-by: Ankita Katiyar <[email protected]>

* Add kedro-telemetry/RELEASE.md to trufflehog ignore

Signed-off-by: Ankita Katiyar <[email protected]>

* Add pytables to test_requirements remove from workflow

Signed-off-by: Ankita Katiyar <[email protected]>

* Revert "Add pytables to test_requirements remove from workflow"

This reverts commit 8203daa.

* Separate pip freeze step

Signed-off-by: Ankita Katiyar <[email protected]>

---------

Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Tingting_Wan <[email protected]>

* Migrate `kedro-docker` to static metadata (#173)

* Migrate kedro-docker to static metadata

See kedro-org/kedro#2334.

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Address packaging warning

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Fix tests

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Actually install current plugin with dependencies

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Add release notes

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

---------

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Tingting_Wan <[email protected]>

* Introdcuing .gitpod.yml to kedro-plugins (#185)

Currently opening gitpod will installed a Python 3.11 which breaks everything because we don't support it set. This PR introduce a simple .gitpod.yml to get it started.

Signed-off-by: Tingting_Wan <[email protected]>

* sync APIDataSet  from kedro's `develop` (#184)

* Update APIDataSet

Signed-off-by: Nok Chan <[email protected]>

* Sync ParquetDataSet

Signed-off-by: Nok Chan <[email protected]>

* Sync Test

Signed-off-by: Nok Chan <[email protected]>

* Linting

Signed-off-by: Nok Chan <[email protected]>

* Revert Unnecessary ParquetDataSet Changes

Signed-off-by: Nok Chan <[email protected]>

* Sync release notes

Signed-off-by: Nok Chan <[email protected]>

---------

Signed-off-by: Nok Chan <[email protected]>
Signed-off-by: Tingting_Wan <[email protected]>

* formatting

Signed-off-by: Tingting_Wan <[email protected]>

* formatting

Signed-off-by: Tingting_Wan <[email protected]>

* formatting

Signed-off-by: Tingting_Wan <[email protected]>

* formatting

Signed-off-by: Tingting_Wan <[email protected]>

* add spark_stream_dataset.py

Signed-off-by: Tingting_Wan <[email protected]>

* restructure the strean dataset to align with the other spark dataset

Signed-off-by: Tingting_Wan <[email protected]>

* adding README.md for specification

Signed-off-by: Tingting_Wan <[email protected]>

* Update kedro-datasets/kedro_datasets/spark/spark_stream_dataset.py

Co-authored-by: Nok Lam Chan <[email protected]>
Signed-off-by: Tingting_Wan <[email protected]>

* rename the dataset

Signed-off-by: Tingting_Wan <[email protected]>

* resolve comments

Signed-off-by: Tingting_Wan <[email protected]>

* fix format and pylint

Signed-off-by: Tingting_Wan <[email protected]>

* Update kedro-datasets/kedro_datasets/spark/README.md

Co-authored-by: Deepyaman Datta <[email protected]>
Signed-off-by: Tingting_Wan <[email protected]>

* add unit tests and SparkStreamingDataset in init.py

Signed-off-by: Tingting_Wan <[email protected]>

* add unit tests

Signed-off-by: Tingting_Wan <[email protected]>

* update test_save

Signed-off-by: Tingting_Wan <[email protected]>

* formatting

Signed-off-by: Tingting_Wan <[email protected]>

* formatting

Signed-off-by: Tingting_Wan <[email protected]>

* formatting

Signed-off-by: Tingting_Wan <[email protected]>

* formatting

Signed-off-by: Tingting_Wan <[email protected]>

* lint

Signed-off-by: Tingting_Wan <[email protected]>

* lint

Signed-off-by: Tingting_Wan <[email protected]>

* lint

Signed-off-by: Tingting_Wan <[email protected]>

* update test cases

Signed-off-by: Tingting_Wan <[email protected]>

* add negative test

Signed-off-by: Tingting_Wan <[email protected]>

* remove code snippets fpr testing

Signed-off-by: Tingting_Wan <[email protected]>

* lint

Signed-off-by: Tingting_Wan <[email protected]>

* update tests

Signed-off-by: Tingting_Wan <[email protected]>

* update test and remove redundacy

Signed-off-by: Tingting_Wan <[email protected]>

* linting

Signed-off-by: Tingting_Wan <[email protected]>

* refactor file format

Signed-off-by: Tom Kurian <[email protected]>

* fix read me file

Signed-off-by: Tom Kurian <[email protected]>

* docs: Add community contributions (#199)

* Add community contributions

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Use newer link to docs

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

---------

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* adding test for raise error

Signed-off-by: Tingting_Wan <[email protected]>

* update test and remove redundacy

Signed-off-by: Tingting_Wan <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* linting

Signed-off-by: Tingting_Wan <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* refactor file format

Signed-off-by: Tom Kurian <[email protected]>

* fix read me file

Signed-off-by: Tom Kurian <[email protected]>

* adding test for raise error

Signed-off-by: Tingting_Wan <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* fix readme file

Signed-off-by: Tom Kurian <[email protected]>

* fix readme

Signed-off-by: Tom Kurian <[email protected]>

* fix conflicts

Signed-off-by: Tom Kurian <[email protected]>

* fix ci erors

Signed-off-by: Tom Kurian <[email protected]>

* fix lint issue

Signed-off-by: Tom Kurian <[email protected]>

* update class documentation

Signed-off-by: Tom Kurian <[email protected]>

* add additional test cases

Signed-off-by: Tom Kurian <[email protected]>

* add s3 read test cases

Signed-off-by: Tom Kurian <[email protected]>

* add s3 read test cases

Signed-off-by: Tom Kurian <[email protected]>

* add s3 read test case

Signed-off-by: Tom Kurian <[email protected]>

* test s3 read

Signed-off-by: Tom Kurian <[email protected]>

* remove redundant test cases

Signed-off-by: Tom Kurian <[email protected]>

* fix streaming dataset configurations

Signed-off-by: Tom Kurian <[email protected]>

* update streaming datasets doc

Signed-off-by: Tingting_Wan <[email protected]>

* resolve comments re documentation

Signed-off-by: Tingting_Wan <[email protected]>

* bugfix lint

Signed-off-by: Tingting_Wan <[email protected]>

* update link

Signed-off-by: Tingting_Wan <[email protected]>

* revert the changes on CI

Signed-off-by: Nok Chan <[email protected]>

* test(docker): remove outdated logging-related step (#207)

* fixkedro- docker e2e test

Signed-off-by: Nok Chan <[email protected]>

* fix: add timeout to request to satisfy bandit lint

---------

Signed-off-by: Nok Chan <[email protected]>
Co-authored-by: Deepyaman Datta <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* ci: ensure plugin requirements get installed in CI (#208)

* ci: install the plugin alongside test requirements

* ci: install the plugin alongside test requirements

* Update kedro-airflow.yml

* Update kedro-datasets.yml

* Update kedro-docker.yml

* Update kedro-telemetry.yml

* Update kedro-airflow.yml

* Update kedro-datasets.yml

* Update kedro-airflow.yml

* Update kedro-docker.yml

* Update kedro-telemetry.yml

* ci(telemetry): update isort config to correct sort

* Don't use profile ¯\_(ツ)_/¯

Signed-off-by: Deepyaman Datta <[email protected]>

* chore(datasets): remove empty `tool.black` section

* chore(docker): remove empty `tool.black` section

---------

Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* ci: Migrate the release workflow from CircleCI to GitHub Actions (#203)

* Create check-release.yml

* change from test pypi to pypi

* split into jobs and move version logic into script

* update github actions output

* lint

* changes based on review

* changes based on review

* fix script to not append continuously

* change pypi api token logic

Signed-off-by: Tom Kurian <[email protected]>

* build: Relax Kedro bound for `kedro-datasets` (#140)

* Less strict pin on Kedro for datasets

Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* ci: don't run checks on both `push`/`pull_request` (#192)

* ci: don't run checks on both `push`/`pull_request`

* ci: don't run checks on both `push`/`pull_request`

* ci: don't run checks on both `push`/`pull_request`

* ci: don't run checks on both `push`/`pull_request`

Signed-off-by: Tom Kurian <[email protected]>

* chore: delete extra space ending check-release.yml (#210)

Signed-off-by: Tom Kurian <[email protected]>

* ci: Create merge-gatekeeper.yml to make sure PR only merged when all tests checked. (#215)

* Create merge-gatekeeper.yml

* Update .github/workflows/merge-gatekeeper.yml

---------

Co-authored-by: Sajid Alam <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* ci: Remove the CircleCI setup (#209)

* remove circleci setup files and utils

* remove circleci configs in kedro-telemetry

* remove redundant .github in kedro-telemetry

* Delete continue_config.yml

* Update check-release.yml

* lint

* increase timeout to 40 mins for docker e2e tests

Signed-off-by: Tom Kurian <[email protected]>

* feat: Dataset API add `save` method (#180)

* [FEAT] add save method to APIDataset

Signed-off-by: jmcdonnell <[email protected]>

* [ENH] create save_args parameter for api_dataset

Signed-off-by: jmcdonnell <[email protected]>

* [ENH] add tests for socket + http errors

Signed-off-by: <[email protected]>
Signed-off-by: jmcdonnell <[email protected]>

* [ENH] check save data is json

Signed-off-by: <[email protected]>
Signed-off-by: jmcdonnell <[email protected]>

* [FIX] clean code

Signed-off-by: jmcdonnell <[email protected]>

* [ENH] handle different data types

Signed-off-by: jmcdonnell <[email protected]>

* [FIX] test coverage for exceptions

Signed-off-by: jmcdonnell <[email protected]>

* [ENH] add examples in APIDataSet docstring

Signed-off-by: jmcdonnell <[email protected]>

* sync APIDataSet  from kedro's `develop` (#184)

* Update APIDataSet

Signed-off-by: Nok Chan <[email protected]>

* Sync ParquetDataSet

Signed-off-by: Nok Chan <[email protected]>

* Sync Test

Signed-off-by: Nok Chan <[email protected]>

* Linting

Signed-off-by: Nok Chan <[email protected]>

* Revert Unnecessary ParquetDataSet Changes

Signed-off-by: Nok Chan <[email protected]>

* Sync release notes

Signed-off-by: Nok Chan <[email protected]>

---------

Signed-off-by: Nok Chan <[email protected]>
Signed-off-by: jmcdonnell <[email protected]>

* [FIX] remove support for delete method

Signed-off-by: jmcdonnell <[email protected]>

* [FIX] lint files

Signed-off-by: jmcdonnell <[email protected]>

* [FIX] fix conflicts

Signed-off-by: jmcdonnell <[email protected]>

* [FIX] remove fail save test

Signed-off-by: jmcdonnell <[email protected]>

* [ENH] review suggestions

Signed-off-by: jmcdonnell <[email protected]>

* [ENH] fix tests

Signed-off-by: jmcdonnell <[email protected]>

* [FIX] reorder arguments

Signed-off-by: jmcdonnell <[email protected]>

---------

Signed-off-by: jmcdonnell <[email protected]>
Signed-off-by: <[email protected]>
Signed-off-by: Nok Chan <[email protected]>
Co-authored-by: jmcdonnell <[email protected]>
Co-authored-by: Nok Lam Chan <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* ci: Automatically extract release notes for GitHub Releases (#212)

* ci: Automatically extract release notes

Signed-off-by: Ankita Katiyar <[email protected]>

* fix lint

Signed-off-by: Ankita Katiyar <[email protected]>

* Raise exceptions

Signed-off-by: Ankita Katiyar <[email protected]>

* Lint

Signed-off-by: Ankita Katiyar <[email protected]>

* Lint

Signed-off-by: Ankita Katiyar <[email protected]>

---------

Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* feat: Add metadata attribute to datasets (#189)

* Add metadata attribute to all datasets

Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* feat: Add ManagedTableDataset for managed Delta Lake tables in Databricks (#206)

* committing first version of UnityTableCatalog with unit tests. This datasets allows users to interface with Unity catalog tables in Databricks to both read and write.

Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* renaming dataset

Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* adding mlflow connectors

Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* fixing mlflow imports

Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* cleaned up mlflow for initial release

Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* cleaned up mlflow references from setup.py for initial release

Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* fixed deps in setup.py

Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* adding comments before intiial PR

Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* moved validation to dataclass

Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* bug fix in type of partition column and cleanup

Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* updated docstring for ManagedTableDataSet

Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* added backticks to catalog

Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* fixing regex to allow hyphens

Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* Update kedro-datasets/kedro_datasets/databricks/managed_table_dataset.py

Co-authored-by: Jannic <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* Update kedro-datasets/kedro_datasets/databricks/managed_table_dataset.py

Co-authored-by: Jannic <[email protected]>
Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* Update kedro-datasets/kedro_datasets/databricks/managed_table_dataset.py

Co-authored-by: Jannic <[email protected]>
Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* Update kedro-datasets/kedro_datasets/databricks/managed_table_dataset.py

Co-authored-by: Jannic <[email protected]>
Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* Update kedro-datasets/kedro_datasets/databricks/managed_table_dataset.py

Co-authored-by: Jannic <[email protected]>
Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* Update kedro-datasets/kedro_datasets/databricks/managed_table_dataset.py

Co-authored-by: Jannic <[email protected]>
Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* Update kedro-datasets/kedro_datasets/databricks/managed_table_dataset.py

Co-authored-by: Jannic <[email protected]>
Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* Update kedro-datasets/test_requirements.txt

Co-authored-by: Jannic <[email protected]>
Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* Update kedro-datasets/kedro_datasets/databricks/managed_table_dataset.py

Co-authored-by: Jannic <[email protected]>
Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* Update kedro-datasets/kedro_datasets/databricks/managed_table_dataset.py

Co-authored-by: Jannic <[email protected]>
Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* Update kedro-datasets/kedro_datasets/databricks/managed_table_dataset.py

Co-authored-by: Jannic <[email protected]>
Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* Update kedro-datasets/kedro_datasets/databricks/managed_table_dataset.py

Co-authored-by: Jannic <[email protected]>
Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* adding backticks to catalog

Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>

* Require pandas < 2.0 for compatibility with spark < 3.4

Signed-off-by: Jannic Holzer <[email protected]>

* Replace use of walrus operator

Signed-off-by: Jannic Holzer <[email protected]>

* Add test coverage for validation methods

Signed-off-by: Jannic Holzer <[email protected]>

* Remove unused versioning functions

Signed-off-by: Jannic Holzer <[email protected]>

* Fix exception catching for invalid schema, add test for invalid schema

Signed-off-by: Jannic Holzer <[email protected]>

* Add pylint ignore

Signed-off-by: Jannic Holzer <[email protected]>

* Add tests/databricks to ignore for no-spark tests

Signed-off-by: Jannic Holzer <[email protected]>

* Update kedro-datasets/kedro_datasets/databricks/managed_table_dataset.py

Co-authored-by: Nok Lam Chan <[email protected]>

* Update kedro-datasets/kedro_datasets/databricks/managed_table_dataset.py

Co-authored-by: Nok Lam Chan <[email protected]>

* Remove spurious mlflow test dependency

Signed-off-by: Jannic Holzer <[email protected]>

* Add explicit check for database existence

Signed-off-by: Jannic Holzer <[email protected]>

* Remove character limit for table names

Signed-off-by: Jannic Holzer <[email protected]>

* Refactor validation steps in ManagedTable

Signed-off-by: Jannic Holzer <[email protected]>

* Remove spurious checks for table and schema name existence

Signed-off-by: Jannic Holzer <[email protected]>

---------

Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>
Co-authored-by: Danny Farah <[email protected]>
Co-authored-by: Danny Farah <[email protected]>
Co-authored-by: Nok Lam Chan <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* docs: Update APIDataset docs and refactor (#217)

* Update APIDataset docs and refactor

* Acknowledge community contributor

* Fix more broken doc

Signed-off-by: Nok Chan <[email protected]>

* Lint

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Fix release notes of upcoming kedro-datasets

---------

Signed-off-by: Nok Chan <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Co-authored-by: Jannic <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* feat: Release `kedro-datasets` version `1.3.0` (#219)

* Modify release version and RELEASE.md

Signed-off-by: Jannic Holzer <[email protected]>

* Add proper name for ManagedTableDataSet

Signed-off-by: Jannic Holzer <[email protected]>

* Update kedro-datasets/RELEASE.md

Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>

* Revert lost semicolon for release 1.2.0

Signed-off-by: Jannic Holzer <[email protected]>

---------

Signed-off-by: Jannic Holzer <[email protected]>
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* docs: Fix APIDataSet docstring (#220)

* Fix APIDataSet docstring

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Add release notes

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Separate [docs] extras from [all] in kedro-datasets

Fix gh-143.

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

---------

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* Update kedro-datasets/tests/spark/test_spark_streaming_dataset.py

Co-authored-by: Deepyaman Datta <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* Update kedro-datasets/kedro_datasets/spark/spark_streaming_dataset.py

Co-authored-by: Deepyaman Datta <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* Update kedro-datasets/setup.py

Co-authored-by: Deepyaman Datta <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>

* fix linting issue

Signed-off-by: Tom Kurian <[email protected]>

---------

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Tingting_Wan <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Ankita Katiyar <[email protected]>
Signed-off-by: Nok Chan <[email protected]>
Signed-off-by: Tom Kurian <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: jmcdonnell <[email protected]>
Signed-off-by: <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Danny Farah <[email protected]>
Signed-off-by: Jannic Holzer <[email protected]>
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Co-authored-by: Tingting Wan <[email protected]>
Co-authored-by: Nok Lam Chan <[email protected]>
Co-authored-by: Deepyaman Datta <[email protected]>
Co-authored-by: Nok Lam Chan <[email protected]>
Co-authored-by: Ankita Katiyar <[email protected]>
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Co-authored-by: Tom Kurian <[email protected]>
Co-authored-by: Sajid Alam <[email protected]>
Co-authored-by: Merel Theisen <[email protected]>
Co-authored-by: McDonnellJoseph <[email protected]>
Co-authored-by: jmcdonnell <[email protected]>
Co-authored-by: Ahdra Merali <[email protected]>
Co-authored-by: Jannic <[email protected]>
Co-authored-by: Danny Farah <[email protected]>
Co-authored-by: Danny Farah <[email protected]>
Co-authored-by: kuriantom369 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants