Use pytest xfail instead of commenting out test

Signed-off-by: Merel Theisen <[email protected]>
kedro-org · Dec 5, 2023 · 9c519cd · 9c519cd
1 parent 04a039a
commit 9c519cd
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 18 deletions.
diff --git a/kedro-datasets/tests/dask/test_parquet_dataset.py b/kedro-datasets/tests/dask/test_parquet_dataset.py
@@ -91,20 +91,21 @@ def test_empty_credentials_load(self, bad_credentials):
         with pytest.raises(DatasetError, match=pattern):
             parquet_dataset.load().compute()
 
-    # def test_pass_credentials(self, mocker):
-    #     """Test that AWS credentials are passed successfully into boto3
-    #     client instantiation on creating S3 connection."""
-    #     client_mock = mocker.patch("botocore.session.Session.create_client")
-    #     s3_dataset = ParquetDataset(filepath=S3_PATH, credentials=AWS_CREDENTIALS)
-    #     pattern = r"Failed while loading data from data set ParquetDataset\(.+\)"
-    #     with pytest.raises(DatasetError, match=pattern):
-    #         s3_dataset.load().compute()
-    #
-    #     assert client_mock.call_count == 1
-    #     args, kwargs = client_mock.call_args_list[0]
-    #     assert args == ("s3",)
-    #     assert kwargs["aws_access_key_id"] == AWS_CREDENTIALS["key"]
-    #     assert kwargs["aws_secret_access_key"] == AWS_CREDENTIALS["secret"]
+    @pytest.mark.xfail
+    def test_pass_credentials(self, mocker):
+        """Test that AWS credentials are passed successfully into boto3
+        client instantiation on creating S3 connection."""
+        client_mock = mocker.patch("botocore.session.Session.create_client")
+        s3_dataset = ParquetDataset(filepath=S3_PATH, credentials=AWS_CREDENTIALS)
+        pattern = r"Failed while loading data from data set ParquetDataset\(.+\)"
+        with pytest.raises(DatasetError, match=pattern):
+            s3_dataset.load().compute()
+
+        assert client_mock.call_count == 1
+        args, kwargs = client_mock.call_args_list[0]
+        assert args == ("s3",)
+        assert kwargs["aws_access_key_id"] == AWS_CREDENTIALS["key"]
+        assert kwargs["aws_secret_access_key"] == AWS_CREDENTIALS["secret"]
 
     def test_save_data(self, s3_dataset, mocked_s3_bucket):
         """Test saving the data to S3."""

diff --git a/kedro-datasets/tests/spark/test_spark_dataset.py b/kedro-datasets/tests/spark/test_spark_dataset.py
@@ -730,10 +730,11 @@ class TestSparkDatasetVersionedS3:
     os.environ["AWS_ACCESS_KEY_ID"] = "FAKE_ACCESS_KEY"
     os.environ["AWS_SECRET_ACCESS_KEY"] = "FAKE_SECRET_KEY"
 
-    # def test_no_version(self, versioned_dataset_s3):
-    #     pattern = r"Did not find any versions for SparkDataset\(.+\)"
-    #     with pytest.raises(DatasetError, match=pattern):
-    #         versioned_dataset_s3.load()
+    @pytest.mark.xfail
+    def test_no_version(self, versioned_dataset_s3):
+        pattern = r"Did not find any versions for SparkDataset\(.+\)"
+        with pytest.raises(DatasetError, match=pattern):
+            versioned_dataset_s3.load()
 
     def test_load_latest(self, mocker, versioned_dataset_s3):
         get_spark = mocker.patch(