Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check presence of scaleTargetRef or jobTargetRef #648

Merged
merged 1 commit into from
Mar 2, 2020
Merged

check presence of scaleTargetRef or jobTargetRef #648

merged 1 commit into from
Mar 2, 2020

Conversation

zroubalik
Copy link
Member

Check presence of scaleTargetRef or jobTargetRef in ScaledObject and log appropriate message.

Fixes #646

ppatierno
ppatierno approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a nit ;-)

@tomkerkhove tomkerkhove merged commit 2de3a4c into kedacore:master Mar 2, 2020
@SatishRanjan SatishRanjan mentioned this pull request Mar 13, 2020
Merged
@zroubalik zroubalik deleted the jobfix branch August 11, 2020 11:32
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
@gunniwho
change tls values from true/false to enable/disable (kedacore#648)
f85f9fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@ppatierno ppatierno ppatierno approved these changes

@Aarthisk Aarthisk Awaiting requested review from Aarthisk

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime error due to nil pointer dereference on TargetRef fields missing
3 participants
@zroubalik @tomkerkhove @ppatierno