Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Added SASL_SSL Plain authentication for Kafka trigger scalar to work with Event Hubs #585

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

rasavant-ms
Copy link
Contributor

  • Added SASL_SSL Plain authentication for Kafka Trigger Scalar.
  • Removed extra newline characters being read from secrets file

This enables connecting Event Hub w/Kafka head as a scalar for KEDA.
Event Hub w/Kafka uses SASL_SSL authentication without certs with just PLAIN mechanism and needs specific TLS config while using the Sarama Go package.

TO DO:

  • Update KEDA documentation to advertise this feature
  • Add sample

@tomkerkhove tomkerkhove added feature All issues for new features that have been committed to scaler-kafka-topic security All issues related to security labels Jan 30, 2020
@tomkerkhove
Copy link
Member

Would you mind also sending a PR for the docs on https://github.com/kedacore/keda-docs

@rasavant-ms
Copy link
Contributor Author

Closes #594

@ahmelsayed ahmelsayed merged commit 964f7f4 into kedacore:master Jan 30, 2020
melmaliacone pushed a commit to melmaliacone/keda that referenced this pull request Jan 31, 2020
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature All issues for new features that have been committed to scaler-kafka-topic security All issues related to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants