Add redis db index option #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se instead of hardcoding db index 0
tomkerkhove
reviewed
Jan 28, 2020
|
Guess we should document also the new option for TLS connections in https://github.com/kedacore/keda-docs/blob/master/content/scalers/redis-lists.md |
|
@tomkerkhove @marchmallow yeah, i'll update the documentation today, and also make the required changes for this PR. |
|
Ok i merged with master, and updated the database name. I tested on databaseIndex 1 and it is working. |
|
Create PR for the documentation too: kedacore/keda-docs#74 |
ahmelsayed
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR let the user choose what database to use instead of hardcoding db index 0.
What is needed is to specify:
dbIdx: Xvalue in the metadata,