-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect optional param for ConfigMaps and Secrets #562
Conversation
LGTM, thanks @tomislater |
Uhh, I do not know how to start writing tests here for something other than I wanted to use fake client like here or here. But, I have got this error:
when I want to create test ScaleHandler:
Do you have any suggestions? Or maybe someone is working on writing tests for handlers? I have tested it on my cluster and it works, but still... :P |
We're using operator-sdk for interacting with kuberentes, so you'll have to create the fake client like this https://github.com/operator-framework/operator-sdk/blob/master/doc/user/unit-testing.md That part is currently only partially covered by the integration tests under |
Thanks, I am going to add tests. |
Thank you very much @tomislater |
I am working on tests, but it might take some time :) I am new here.
#555