Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Review e2e tests #5610

Merged
merged 12 commits into from
Mar 30, 2024
Merged

fix: Review e2e tests #5610

merged 12 commits into from
Mar 30, 2024

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Mar 17, 2024

A bunch of e2e test improvements, such us:

  • pause_scaledjob_test.go is a flaky test because it's based on passed times during specific moments and it can depend on cluster state. This PR changes the test adding different checks to validate the different statuses, not depending on checking the things in the exact moment.
  • scaling_modifiers_test.go doesn't validate that the mock metrics server is ready before starting the tests, producing errors because the test starts without the mocks ready
  • pentelemetry test doesn't validate the lag metric values as it's not relevant for the test, but it introduces a not controlled variable which makes the test fail
  • rabbitmq helper now waits until the server is ready
  • etcd scaler uses helm chart for deploying etcd
  • tests fail fast if there is any issue with dependencies (e.g: if Kafka cluster doesn't start, we fail the tests directly instead of waiting until the end)

TODOs:

  • There is an issue in rabbitmq server which produces failures with oauth. The issue is fixed and the release was cut, but we have to wait until docker releases the version too. In the meantime I have just downgraded the version, but we should use the fixed one once it's released

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5547

Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer requested a review from a team as a code owner March 17, 2024 16:52
@JorTurFer JorTurFer enabled auto-merge (squash) March 17, 2024 19:51
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer changed the title fix: Refactor paused e2e test fix: Refactor paused e2e test and scaling modifiers Mar 17, 2024
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer changed the title fix: Refactor paused e2e test and scaling modifiers fix: Review e2e tests Mar 25, 2024
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer mentioned this pull request Mar 27, 2024
7 tasks
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Mar 29, 2024

/run-e2e
Update: You can check the progress here

Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Mar 29, 2024

/run-e2e
Update: You can check the progress here

Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
Copy link
Member Author

JorTurFer commented Mar 30, 2024

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Mar 30, 2024

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Mar 30, 2024

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Mar 30, 2024

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Mar 30, 2024

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer merged commit f2d86a8 into kedacore:main Mar 30, 2024
19 checks passed
@JorTurFer JorTurFer deleted the fix-e2e branch March 30, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail fast during e2e tests if dependencies aren't ready
2 participants