Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy ScaledJob annotations to child Jobs #5106

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Copy ScaledJob annotations to child Jobs #5106

merged 3 commits into from
Oct 26, 2023

Conversation

josefkarasek
Copy link
Member

@josefkarasek josefkarasek commented Oct 20, 2023 •
edited by zroubalik
Loading

  • ScaledJob annotations are applied to child Jobs, including some basic tests

Checklist

Fixes #4594

@josefkarasek josefkarasek requested a review from a team as a code owner October 20, 2023 15:24
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

zroubalik
zroubalik requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  • fix DCO
  • fix static checks
  • add documentation to keda-docs

wozniakjan
wozniakjan reviewed Oct 25, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pkg/scaling/executor/scale_jobs_test.go Outdated Show resolved Hide resolved
@josefkarasek josefkarasek mentioned this pull request Oct 25, 2023
Merged
1 task
Josef Karasek added 3 commits October 25, 2023 18:36
Copy ScaledJob annotations to child Jobs
6a13875 
Signed-off-by: Josef Karasek <[email protected]>
fix lint issues
25bb0b8 
Signed-off-by: Josef Karasek <[email protected]>
fix missing semicollon
787b662 
Signed-off-by: Josef Karasek <[email protected]>
@zroubalik
Copy link
Member

zroubalik commented Oct 26, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

zroubalik
zroubalik approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik enabled auto-merge (squash) October 26, 2023 16:41
@zroubalik zroubalik merged commit 0006e57 into kedacore:main Oct 26, 2023
18 checks passed
@zroubalik zroubalik mentioned this pull request Oct 27, 2023
Closed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@josefkarasek @toniiiik
Copy ScaledJob annotations to child Jobs (kedacore#5106)
40df13b 
Signed-off-by: Josef Karasek <[email protected]>
Co-authored-by: Josef Karasek <[email protected]>
Signed-off-by: anton.lysina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

annotations for the job object of a scaledjob
3 participants
@josefkarasek @zroubalik @wozniakjan