Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e test command #2708

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Fix e2e test command #2708

merged 2 commits into from
Mar 2, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Mar 2, 2022

Signed-off-by: Jorge Turrado [email protected]

Locally, both multiarch Dockerfile work without the variables but in the CI, the default values are necessary for Dockerfile arguments.
This PR also adds a workflow which builds docker images (only build) if any change is detected in Dockerfiles to avoid this problem in the future

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Related #2263

@JorTurFer JorTurFer marked this pull request as ready for review March 2, 2022 18:42
@JorTurFer JorTurFer requested a review from a team as a code owner March 2, 2022 18:42
@JorTurFer JorTurFer changed the title WIP - Fix e2e test command Fix e2e test command Mar 2, 2022
@JorTurFer JorTurFer merged commit 98c72a9 into kedacore:main Mar 2, 2022
@JorTurFer JorTurFer deleted the fix_pr_e2e branch March 2, 2022 19:47
@JorTurFer JorTurFer mentioned this pull request Mar 6, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants