Add Cassandra scaler #1817
Closed
Add Cassandra scaler #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
zroubalik
reviewed
May 24, 2021
There was a problem hiding this comment.
Thank you for you contribution! Is this PR ready for a review? I haven't yet check the code properly, have some input though:
- could you please add unit test as it is done for the rest of the scalers (`cassandar_scaler_test.go)?
- could you please add e2e test for this scaler? (in this case probably an ephemeral deployment of Cassandra on k8s and checking that applied ScaledObject scales some target deployment (similar as it is implemented in e2e tests for other scalers) https://github.com/kedacore/keda/tree/main/tests
config/manager/kustomization.yaml
Outdated
| @@ -5,5 +5,5 @@ apiVersion: kustomize.config.k8s.io/v1beta1 | |||
| kind: Kustomization | |||
There was a problem hiding this comment.
Please exclude this file from your PR.
| @@ -10,5 +10,5 @@ apiVersion: kustomize.config.k8s.io/v1beta1 | |||
| kind: Kustomization | |||
There was a problem hiding this comment.
Please exclude this file from your PR.
|
I will add them as soon as possible :) And will delete those 2 files, too. Thank you for the review! |
Signed-off-by: nilayasiktoprak <[email protected]>
Signed-off-by: nilayasiktoprak <[email protected]>
Signed-off-by: nilayasiktoprak <[email protected]>
nilayasiktoprak
force-pushed
the
cassandra_scaler
branch
from
57b1c9e to
da81219
Compare
Signed-off-by: nilayasiktoprak <[email protected]>
|
This PR is moved to #1841 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nilayasiktoprak [email protected]
Add a new Cassandra scaler.
Checklist
Relates to #1738