-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft SQL Server (MSSQL) scaler implementation #1591
Conversation
Signed-off-by: Chris Gillum <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this upstream @cgillum!
Can you please:
- Update our changelog (https://github.com/kedacore/keda/blob/main/CHANGELOG.md)
- Open a PR for our docs (https://github.com/kedacore/keda-docs)
Thanks!
Signed-off-by: Chris Gillum <[email protected]>
Signed-off-by: Chris Gillum <[email protected]>
@cgillum Can we mark the PR as ready for review or is there any open work? |
@tomkerkhove still working on putting together end-to-end tests for this one. I'm learning as I go (first time deploying a real k8s cluster), so apologies for the delay. |
Oh no worries at all! I was just checking if you were waiting on us or not! |
@cgillum can't help you but you have my moral support to finish your e2e test :) this scaler would be great to have |
Signed-off-by: Chris Gillum <[email protected]>
@tomkerkhove and @ahmelsayed, I was able to complete my e2e testing successfully and I think this PR is ready to go. Would it be okay to defer the authoring of the e2e test for another PR or should that also be part of this PR? |
@cgillum yes that's fine, e2e test can come in a separate PR |
Signed-off-by: Chris Gillum <[email protected]>
I ended up getting an end-to-end test working sooner than I thought, so I went ahead and added it to this PR in my latest iteration. It's basically the same as the mysql test with a few tweaks and simplifications. Please let me know if the way that it is written is acceptable, especially regarding the dependency on my docker hub test container image. |
Signed-off-by: Chris Gillum <[email protected]>
If you have a test container, we could host it on our test container repo if you want? |
It probably makes more sense to eventually host it in a KEDA-specific container repo so that I don't accidentally break anything in the future. That said, this doesn't have to happen right away. We could move it as part of a separate PR once we know that the nightly tests are stable. |
Sure thing, no worries! Will wait for @ahmelsayed his review. Thanks! |
* Initial implementation and tests for mssql scaler Signed-off-by: Chris Gillum <[email protected]> * PR feedback and minor doc updates Signed-off-by: Chris Gillum <[email protected]> * Fixed mssql driver loading issue Signed-off-by: Chris Gillum <[email protected]> * Added end-to-end test Signed-off-by: Chris Gillum <[email protected]> * Removing trailing whitespace Signed-off-by: Chris Gillum <[email protected]>
* Initial implementation and tests for mssql scaler Signed-off-by: Chris Gillum <[email protected]> * PR feedback and minor doc updates Signed-off-by: Chris Gillum <[email protected]> * Fixed mssql driver loading issue Signed-off-by: Chris Gillum <[email protected]> * Added end-to-end test Signed-off-by: Chris Gillum <[email protected]> * Removing trailing whitespace Signed-off-by: Chris Gillum <[email protected]>
This PR adds a built-in scaler that uses a Microsoft SQL Server (MSSQL) database as the event source. It's very similar to both the existing mysql and postgresql scalers and is intended to work with both self-hosted SQL Server databases and SQL Server databases hosted in managed clouds.
Documentation PR: kedacore/keda-docs#367
There is still more work to do on this PR, which is tracked in the checklist below. This also includes end-to-end testing. However, I wanted to open it early to hopefully get some early feedback since this is both my first contribution to KEDA and my first time writing code in Go (besides hello world). Feedback is greatly appreciated. 🙏🏽
Checklist
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)(doesn't seem like this is necessary)Fixes #674