Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ScaledJob finalizer #1260

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Adding ScaledJob finalizer #1260

merged 1 commit into from
Oct 15, 2020

Conversation

zroubalik
Copy link
Member

@zroubalik zroubalik commented Oct 15, 2020

Signed-off-by: Zbynek Roubalik [email protected]

ScaledJob wasn't properly finalized -> ScaleLoop was running even if the ScaledJob resource was deleted.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #1247

Signed-off-by: Zbynek Roubalik <[email protected]>
Copy link
Contributor

@TsuyoshiUshio TsuyoshiUshio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 4b4e473 into kedacore:v2 Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keda keeps managing deleted ScaledJobs
2 participants