Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add targetQueryValue param to postgreSQL scaler docs #98

Merged
merged 1 commit into from
Feb 26, 2020
Merged

add targetQueryValue param to postgreSQL scaler docs #98

merged 1 commit into from
Feb 26, 2020

Conversation

dimberman
Copy link
Contributor

No description provided.

@dimberman dimberman mentioned this pull request Feb 26, 2020
Merged
2 tasks
@tomkerkhove
Copy link
Member

LGTM but will wait for PR to be merged!

@ahmelsayed
Copy link
Contributor

LGTM too. I merged the other PR.

@tomkerkhove tomkerkhove merged commit 6e840ce into kedacore:master Feb 26, 2020
VojtechVitek
VojtechVitek reviewed Aug 21, 2020
View reviewed changes
Copy link

@VojtechVitek VojtechVitek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think targetQueryValue gotta be a string. I got some errors with an integer.

targetQueryValue: "1"

VojtechVitek
VojtechVitek reviewed Aug 21, 2020
View reviewed changes
Copy link

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a threshold that is used as targetAverageValue in HPA.

I'm new to this, but just from reading the docs, it's not really obvious to me what this value does.

@tomkerkhove
Copy link
Member

@dimberman Is it correct that targetQueryValue should be a string?

@VojtechVitek
Copy link

I believe so: https://github.com/kedacore/keda/pull/643/files#diff-297972b04c7b8fc82074c50315b35d3dR68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VojtechVitek VojtechVitek VojtechVitek left review comments

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@jeffhollan jeffhollan Awaiting requested review from jeffhollan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dimberman @tomkerkhove @ahmelsayed @VojtechVitek @astro-sql-decorator